Bug 1417029

Summary: setUp and tearDown no longer call reset
Product: [Fedora] Fedora Reporter: Garrett Holmstrom <gholms>
Component: python-httprettyAssignee: Jamie Lennox <jamielennox>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 25CC: jamielennox, piotr1212
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: python-httpretty-0.8.14-2.20161011git70af1f8.fc25 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-02-09 04:21:39 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Garrett Holmstrom 2017-01-27 02:59:51 UTC 
Description of problem:
When test cases are decorated with the setUp and tearDown that came in via python-httpretty-0.8.14-1.20161011git70af1f8.fc25, httpretty.reset() is not called as it is if one used decorate_callable() -> httprettized().  In this code path, only enable and disable are called.  This is a regression that occurred in between version 0.8.14 and the git snapshot that went stable in all active releases on 2017-01-24.  We discovered it when several of cloud-init's unit tests broke.


Version-Release number of selected component (if applicable):
python-httpretty-0.8.14-1.20161011git70af1f8.el7.noarch


Additional info:

The upstream bug report and a proposed patch are available here:
https://github.com/gabrielfalcao/HTTPretty/issues/316
https://github.com/gabrielfalcao/HTTPretty/pull/317
Comment 1 Fedora Update System 2017-01-27 23:14:02 UTC 
python-httpretty-0.8.14-2.20161011git70af1f8.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-64f8e59b99
Comment 2 Garrett Holmstrom 2017-01-27 23:49:25 UTC 
That seems to fix the cloud-init tests, at least on el7.  Thanks!
Comment 3 Fedora Update System 2017-01-29 02:22:37 UTC 
python-httpretty-0.8.14-2.20161011git70af1f8.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-64f8e59b99
Comment 4 Fedora Update System 2017-02-09 04:21:39 UTC 
python-httpretty-0.8.14-2.20161011git70af1f8.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.