Bug 1417405
Summary: | Review Request: prelude-lml | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Thomas Andrejak <thomas.andrejak> |
Component: | Package Review | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | rawhide | CC: | package-review, zbyszek |
Target Milestone: | --- | Flags: | zbyszek:
fedora-review+
|
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2017-02-22 14:49:19 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Thomas Andrejak
2017-01-28 19:11:53 UTC
It'd drop stuff like %{__mkdir_p} → mkdir -p is just as good. It's not like anyone is ever going to rebuild this rpm on a system without a working mkdir. IMHO, doing stuff like that is just an obsolete legacy of configure scripts from 80's and 90's. (Same for chrpath, install.) In addition, it's ugly to use the macro in one place, and then write 'mkdir -p' a few lines down. %config %{_unitdir}/%{name}.service → nope, that's not config. Just a normal file. If somebody needs to tweak it, they should place stuff in /etc/systemd. Hm, on my 12-core system, test-lock runs and runs and runs (currently 21h+ of CPU time). I'll fire of another build on koji, let's see how that goes. rpmlint: prelude-lml.x86_64: W: crypto-policy-non-compliance-gnutls-1 /usr/sbin/prelude-lml gnutls_priority_set_direct prelude-lml.x86_64: W: non-ghost-in-run /run/prelude-lml Not sure about this one. I couldn't find anything in the guidelines, and a few packages I looked at do not use %ghost. I guess that if you want the directory to be available immediately after the package is installed, current version is reasonable. Seems OK as is. Let's see if it builds in koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=17483847 Hello Thanks for the review SPEC : https://fedorapeople.org/~totol/prelude-lml.spec SRPM : https://fedorapeople.org/~totol/prelude-lml-3.1.0-1.fc26.src.rpm (In reply to Zbigniew Jędrzejewski-Szmek from comment #1) > It'd drop stuff like %{__mkdir_p} → mkdir -p is just as good. It's not like > anyone is ever going to rebuild this rpm on a system without a working > mkdir. IMHO, doing stuff like that is just an obsolete legacy of configure > scripts from 80's and 90's. (Same for chrpath, install.) In addition, it's > ugly to use the macro in one place, and then write 'mkdir -p' a few lines > down. Done > > %config %{_unitdir}/%{name}.service → nope, that's not config. Just a normal > file. If somebody needs to tweak it, they should place stuff in /etc/systemd. > Done (I read it too fast ...) > Hm, on my 12-core system, test-lock runs and runs and runs (currently 21h+ > of CPU time). I'll fire of another build on koji, let's see how that goes. Yes I had this one time with koji. I don't know why and I can't reproduce it. Plus, I never see this happens on another system, just with koji. I have to cancel and then start the task again and it pass. > > rpmlint: > prelude-lml.x86_64: W: crypto-policy-non-compliance-gnutls-1 > /usr/sbin/prelude-lml gnutls_priority_set_direct As I said in first message, false positive, I fixed it with a patch > > prelude-lml.x86_64: W: non-ghost-in-run /run/prelude-lml > Not sure about this one. I couldn't find anything in the guidelines, and a > few packages I looked at do not use %ghost. I guess that if you want the > directory to be available immediately after the package is installed, > current version is reasonable. Seems OK as is. Guidelines : https://fedoraproject.org/wiki/Packaging:Tmpfiles.d , see the spec example. I don't know which is the right way > > Let's see if it builds in koji: > https://koji.fedoraproject.org/koji/taskinfo?taskID=17483847 + package name is OK
+ license is acceptable (GPLv2+)
+ license is specified corretly
+ provides/requires/BRs look correct
+ scriptlets follow the guidelines
+ rpmlint output was discussed above and is OK
Package is APPROVED.
> Let's see if it builds in koji:
> https://koji.fedoraproject.org/koji/taskinfo?taskID=17483847
This one's hanging in test_lock.
I also rebuilt the package a few times on my workstation, and it about 5 tries to hang. This time test_lock passed, but test_rwlock hung:
(I don't know if this relevant, but the machine has a few multithreaded java processes consuming ~5 cores. It's possible that this increases the likelihood.)
For some reason I'm not able to get a useful stack trace. gdb says:
warning: .dynamic section for "target:/lib64/librt.so.1" is not at the expected address (wrong library or version mismatch?)
warning: .dynamic section for "target:/lib64/libm.so.6" is not at the expected address (wrong library or version mismatch?)
warning: .dynamic section for "target:/lib64/ld-linux-x86-64.so.2" is not at the expected address (wrong library or version mismatch?)
Missing separate debuginfo for target:/lib64/librt.so.1
But the latest debuginfo packages are installed. There were new glibc packages built yesterday, maybe it's the fallout from that.
Hm, the process name seems to be test-lock, it's the test case test_rwlock (or something like that, I'm leaving the debugging to you ;)) Thanks for these information ! prelude-lml-3.1.0-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-e9e7bcbb6c prelude-lml-3.1.0-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-f7c895b586 prelude-lml-3.1.0-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-f7c895b586 prelude-lml-3.1.0-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-e9e7bcbb6c prelude-lml-3.1.0-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-c9f60edbb8 prelude-lml-3.1.0-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-c9f60edbb8 prelude-lml-3.1.0-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-c9f60edbb8 prelude-lml-3.1.0-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-f7c895b586 prelude-lml-3.1.0-2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-e9e7bcbb6c prelude-lml-3.1.0-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-f7c895b586 prelude-lml-3.1.0-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-c9f60edbb8 prelude-lml-3.1.0-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-e9e7bcbb6c prelude-lml-3.1.0-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. prelude-lml-3.1.0-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. prelude-lml-3.1.0-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. |