Bug 1417444

Summary:	*** No rule to make target '../perl/lib/Sys/Guestfs.c', needed by 'libguestfs.pot'
Product:	[Community] Virtualization Tools	Reporter:	Marius Cirsta <mforce2>
Component:	libguestfs	Assignee:	Richard W.M. Jones <rjones>
Status:	CLOSED UPSTREAM	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	unspecified	CC:	ptoscano, rbalakri
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-01-29 13:35:17 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Marius Cirsta 2017-01-29 12:38:05 UTC

Description of problem:
I got this error with when compiling 1.34.3 even though I did disable the perl bindings.

Version-Release number of selected component (if applicable):
1.34.3

How reproducible:
Compile with perl bindings disabled.

Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Richard W.M. Jones 2017-01-29 13:30:31 UTC

This is a build bug, but it's not a particularly important one.  You
can either skip over it (make -k) or `touch` the missing file,
and the build should be fine.

However the bug is interesting.  perl/lib/Sys/Guestfs.c doesn't contain
any translatable strings, and there is supposed to be excluded from
po/POTFILES by this line:

https://github.com/libguestfs/libguestfs/blob/48d4117789e92489b9a3c6f3456b0770b3fdb290/Makefile.am#L334

but despite that the file still gets listed in po/POTFILES.  So I
wonder why that is ...

Comment 2 Marius Cirsta 2017-01-29 13:33:49 UTC

 I was able to easily fix it but I just thought you should know about it and maybe fix.
 It's always nice to have a clean build no matter what configuration you choose.

Comment 3 Richard W.M. Jones 2017-01-29 13:35:04 UTC

Oh I see, the regexp is wrong.  Fixed in:

https://github.com/libguestfs/libguestfs/commit/c9a51b2fd27b269f5250904040667282ffaaebbb

which will be in libguestfs 1.35.21 & 1.34.4.