Bug 1417549

Can you see if this patch fixes it?

diff --git a/fish/Makefile.am b/fish/Makefile.am
index fa345d6..d806ebf 100644
--- a/fish/Makefile.am
+++ b/fish/Makefile.am
@@ -137,14 +137,15 @@ guestfish_CFLAGS = \
        $(LIBXML2_CFLAGS)
 
 guestfish_LDADD = \
-       $(LIBCONFIG_LIBS) \
-       $(LIBREADLINE) \
        $(top_builddir)/common/edit/libedit.la \
        $(top_builddir)/common/options/liboptions.la \
        $(top_builddir)/common/progress/libprogress.la \
        $(top_builddir)/common/utils/libutils.la \
        $(top_builddir)/lib/libguestfs.la \
        $(LIBXML2_LIBS) \
+       $(LIBCONFIG_LIBS) \
+       $(LIBREADLINE) \
+       $(LIBTINFO_LIBS) \
        $(LTLIBINTL) \
        -lm

# git apply --stat ../bug.patch 
 fish/Makefile.am |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
# git apply --check ../bug.patch 
error: patch failed: fish/Makefile.am:137
error: fish/Makefile.am: patch does not apply

I don't understand what that means.  However I will attach
the patch directly to the BZ to avoid any copy and paste problems.

Created attachment 1246114 [details]
0001-fish-Link-to-libtinfo-RHBZ-1417549.patch

Issue still there with v1.35.23.

Please try the patch.

https://bugzilla.redhat.com/show_bug.cgi?id=1417549#c2

I'm closing this.  Please show some good will when we are
attempting to help you with fixes.

Same issue in v1.35.24

I have just verified that the patch still applies to the
latest version.  Please try it and see if it fixes the problem
for you.  We do not see this bug on our local builds.

Applying the "0001-fish-Link-to-libtinfo-RHBZ-1417549.patch" patch on v1.35.24 leads to the same issue.
You don't see it probably because you build with another OS.

FYI, I've successfully built numerous libguestfs releases (up to v1.35.19) in the past in the exact same environment.

(In reply to jean-christophe manciot from comment #11)
> Applying the "0001-fish-Link-to-libtinfo-RHBZ-1417549.patch" patch on
> v1.35.24 leads to the same issue.

What are the exact steps you are doing to test it?  I'm asking this because, when building from a release tarball, you need to autoreconf the sources (running `autoreconf -fi` from the top-level) so that the changes in autoconf (such as configure.ac, and the various *.m4 files) and automake files (such as the Makefile.am files) are correctly propagated to the static files of the autotools-based dist.

I hit the same issue when testing on openSUSE Factory, and Ubuntu devel, and the patch worked in both cases.  So I'd simply commit it, so it can be available also in release tarballs in libguestfs >= 1.35.25.

You already have your answer https://bugzilla.redhat.com/show_bug.cgi?id=1417549#c0.

Also, the script "git-reset-clean-pull-checkout.sh $branch $tag" does the following:
git_branch=$1
git_tag=$2

echo -------------------------
echo "Checking out $git_branch"
echo -------------------------
git checkout $git_branch
echo ---------------------
echo "Resetting & cleaning"
echo ---------------------
git reset --hard
git submodule foreach --recursive git reset --hard
git clean -fxd :/
echo -------------------------
echo "Checking out $git_branch"
echo -------------------------
git checkout $git_branch
echo --------------------
echo "Pulling with rebase"
echo --------------------
git pull -v --progress --rebase
return_code=$?
if [ $return_code -ne 0 ]; then
        exit $return_code
fi
git submodule update --init --recursive
git fetch --tags
git checkout $git_tag

exit 0

I just pushed the patch, as it was fixing the issue for me:
https://github.com/libguestfs/libguestfs/commit/1230543f7159c8a936b52eda792340c9759a420b
It will be in libguestfs >= 1.35.25.

Do you have hardening-wrapper installed, by chance?

I'll wait then and yes.

Just tried, and git/master (which includes the patch) builds fine also with hardening-wrapper installed -- thus, marking it as fixed.

Yes, this issue is solved, even though there are other issues during the test process "make check".