Bug 1417627
| Summary: | RFE: show hint how to display why package was skipped | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Peter Gervase <pgervase> |
| Component: | dnf | Assignee: | Honza Silhan <jsilhan> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | low | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | jmracek, packaging-team-maint, rpm-software-management, vmukhame |
| Target Milestone: | --- | Keywords: | EasyFix, FutureFeature, Triaged |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | dnf-2.1.0-1.fc26 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-02-16 13:45:53 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Peter Gervase
2017-01-30 13:10:11 UTC
Use --best if you want to get errors. We should provide hint after "Skipping packages with broken dependencies:" section: ~"To get the root cause why the single package was skipped, rerun "dnf --best <command> <packagename>" (In reply to Igor Gnatenko from comment #1) > Use --best if you want to get errors. No no. I'm not talking about anything out of the ordinary. If I run dnf like normal and then check with echo $? to see if it completed successfully, that shouldn't return 0 if dnf doesn't actually fully complete the update or whatever command. Running an update and skipping those packages that have broken deps is not a successful run. That's great that dnf doesn't update packages that don't have all of the deps met, but that doesn't mean it was successfully run. Oh no! heartbleed / dirtycow / badlock ... and I need to patch! I'd better run dnf update. It said it skipped packages, but it returned 0 so that must mean I'm patched. (In reply to Honza Silhan from comment #2) > We should provide hint after "Skipping packages with broken dependencies:" > section: ~"To get the root cause why the single package was skipped, rerun > "dnf --best <command> <packagename>" That would be nice, but this bug was initially for dnf (incorrectly) returning 0 when it didn't fully run without issue. PR: https://github.com/rpm-software-management/dnf/pull/735 (In reply to Peter Gervase from comment #3) > (In reply to Igor Gnatenko from comment #1) > > Use --best if you want to get errors. > > No no. I'm not talking about anything out of the ordinary. If I run dnf like > normal and then check with echo $? to see if it completed successfully, that > shouldn't return 0 if dnf doesn't actually fully complete the update or > whatever command. Running an update and skipping those packages that have > broken deps is not a successful run. That's great that dnf doesn't update > packages that don't have all of the deps met, but that doesn't mean it was > successfully run. > Oh no! heartbleed / dirtycow / badlock ... and I need to patch! I'd better > run dnf update. It said it skipped packages, but it returned 0 so that must > mean I'm patched. Returning non-0 code while doing partial update when user requested it is not correct. IIRC yum returns 0 when you add --skip-broken switch and because of persisting compatibility we cannot change that. > (In reply to Honza Silhan from comment #2) > > We should provide hint after "Skipping packages with broken dependencies:" > > section: ~"To get the root cause why the single package was skipped, rerun > > "dnf --best <command> <packagename>" > > That would be nice, but this bug was initially for dnf (incorrectly) > returning 0 when it didn't fully run without issue. run it with `--best` as advised above. Then it will halt and return non-0 code. |