Bug 1417631
| Summary: | Review Request: mingw-libftdi - MinGW library to program and control the FTDI USB controller | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Thomas Sailer <fedora> |
| Component: | Package Review | Assignee: | Robert-André Mauchin 🐧 <eclipseo> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | eclipseo, fedora-mingw, fedora, package-review |
| Target Milestone: | --- | Flags: | eclipseo:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-10-11 14:47:11 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1417628 | ||
| Bug Blocks: | |||
|
Description
Thomas Sailer
2017-01-30 13:21:11 UTC
Hello,
- As before, list of things not needed in Fedora:
+ Group: System Environment/Libraries
+ BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
+ rm -rf $RPM_BUILD_ROOT
+ %clean
+ %defattr(-,root,root,-)
- You need to include the various license files in %license:
%license LICENSE COPYING.LIB COPYING.GPL
- The License: field should reflect the licenses included, that is, the C++ wrapper "ftdipp1" is distributed under the GNU General Public License version 2 and the C library "libftdi1" is distributed under the GNU Library General Public License version 2:
License: GPLv2 and LGPLv2
- %doc should probably include:
%doc AUTHORS ChangeLog README
- You should probably not include the full documentation at all, which comes at a hefty 12MB. See https://fedoraproject.org/wiki/Packaging:MinGW#Files_which_are_already_part_of_native_packages
Merci Robert-André! I should have addressed all of your concerns in this update: Spec URL: https://sailer.fedorapeople.org/mingw-libftdi.spec SRPM URL: https://sailer.fedorapeople.org/mingw-libftdi-1.3-2.fc26.src.rpm copr build: https://copr.fedorainfracloud.org/coprs/sailer/mingw/build/618089/ In the license tag, you've written twice LGPLv2' instead of: License: GPLv2 and LGPLv2 Thanks for spotting this Spec URL: https://sailer.fedorapeople.org/mingw-libftdi.spec SRPM URL: https://sailer.fedorapeople.org/mingw-libftdi-1.3-3.fc26.src.rpm Ok, package accepted. (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/mingw-libftdi mingw-libftdi-1.3-3.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-d10ac2855e mingw-libftdi-1.3-3.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-e0a3aec644 mingw-libftdi-1.3-3.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-e0a3aec644 mingw-libftdi-1.3-3.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-d10ac2855e mingw-libftdi-1.3-3.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. mingw-libftdi-1.3-3.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. |