Bug 1417864

Summary: Qemu-kvm starts with unspecified port
Product: Red Hat Enterprise Linux 7 Reporter: Radek Duda <rduda>
Component: qemu-kvmAssignee: Marc-Andre Lureau <marcandre.lureau>
Status: CLOSED ERRATA QA Contact: Chao Yang <chayang>
Severity: low Docs Contact:
Priority: unspecified    
Version: 7.4CC: chayang, juzhang, knoel, michen, qzhang, rbalakri, rduda, spice-qe-bugs, virt-maint, zhguo
Target Milestone: rc   
Target Release: ---   
Hardware: x86_64   
OS: Unspecified   
Fixed In Version: qemu-kvm-1.5.3-148.el7 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-04-10 14:32:19 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Radek Duda 2017-01-31 10:32:56 UTC
Description of problem:
If qemu-kvm command is launched with unspecified port option (e.g. "-spice port="), it starts normally.

Version-Release number of selected component (if applicable):
and qemu-kvm-rhev.2.6.0-28.el7.x86_64

How reproducible:

Steps to Reproduce:
1.Start VM with unspecified spice port ('-spice port=') for example:
/usr/libexec/qemu-kvm -machine pc  -nodefaults  -vga qxl   -device intel-hda,bus=pci.0,addr=03  -device hda-duplex -device virtio-serial-pci,id=virtio_serial_pci0,bus=pci.0,addr=04 -chardev spicevmc,id=idSwuYmk,name=vdagent -devicevirtserialport,id=idBWNLHY,name=com.redhat.spice.0,bus=virtio_serial_pci0.0,chardev=idSwuYmk -drive id=drive_image1,if=none,cache=none,format=qcow2,file=Rhel7.2 -device virtio-blk-pci,id=image1,drive=drive_image1,bootindex=0,bus=pci.0,addr=05 -m 1024 -spice disable-ticketing,port=  -monitor stdio

Actual results:
VM starts normally. 
(qemu) info spice -> No listening address specified

Expected results:
qemu-kvm will exit with code 1, and following message:
'neither port nor tls-port specified for spice' or something like this

Comment 2 Marc-Andre Lureau 2017-02-06 13:32:56 UTC
Sent one-liner  patch "[PATCH] qemu-option: reject empty number value", not sure it's really going to happen, foo= default to value 0 is perhaps an acceptable behaviour.

Comment 3 Marc-Andre Lureau 2017-03-20 08:19:45 UTC
Fixed from 2.9:

commit 3403e5eb884f3a74c40fe7cccc103f848c040215
Author: Markus Armbruster <armbru>
Date:   Tue Feb 21 21:13:53 2017 +0100

    option: Fix to reject invalid and overflowing numbers

Comment 4 Marc-Andre Lureau 2017-06-06 10:10:06 UTC
sent patch to rhvirt-list "[RHEL-7.4 qemu-kvm PATCH] qemu-option: reject empty number value"

Comment 5 Marc-Andre Lureau 2017-11-03 18:09:45 UTC
sent new version "[RHEL-7.5 qemu-kvm PATCH v2] qemu-option: reject empty number value"

Comment 6 Miroslav Rezanina 2017-11-10 02:48:46 UTC
Fix included in qemu-kvm-1.5.3-148.el7

Comment 12 errata-xmlrpc 2018-04-10 14:32:19 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.