Bug 1417938

Summary:	Incorrect error message displayed when hot pluging cpu sockets from vsphere vm
Product:	Red Hat CloudForms Management Engine	Reporter:	luke couzens <lcouzens>
Component:	Appliance	Assignee:	Adam Grare <agrare>
Status:	CLOSED CURRENTRELEASE	QA Contact:	luke couzens <lcouzens>
Severity:	medium	Docs Contact:
Priority:	high
Version:	5.7.0	CC:	abellott, dajohnso, gblomqui, jhardy, obarenbo
Target Milestone:	GA
Target Release:	cfme-future
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	reconfigure:vmware
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-03-06 16:24:04 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description luke couzens 2017-01-31 13:08:36 UTC

Description of problem:If you decrease cpu socket count from a vsphere vm while powered on you receive an inaccurate error message.

Version-Release number of selected component (if applicable):5.7.1.0


How reproducible:100%


Steps to Reproduce:
1.Add vsphere provider to CFME appliance
2.Provision new vm (rhel7 in my case)
3.Turn on cpu hot plug withing VMWare
4.Reconfigure the vm reducing its cpu socket count

Actual results: Error: CPU hot plug is not supported for this virtual machine.


Expected results:I believe the correct error should be something like: 'unable to decrease cpu count in powered on state'.


Additional info:
Test was ran with vsphere 5.5 provider

Comment 2 Adam Grare 2017-03-06 16:24:04 UTC

This was fixed by https://github.com/ManageIQ/manageiq/pull/12275 and is in 5.8
We validate the requested changes against the hot-plug settings on the VM and print a more informative error message, in this case it will read "Error: Cannot remove CPUs from a running VM"

It should be noted that the error message that you reported actually comes from VMware not CFME, the reason being that while cpu-hot-add is enabled cpu-hot-remove is not, they just have one error message to report that.

That PR depends on a SQL migration (https://github.com/ManageIQ/manageiq/pull/12145) hence why it was not backported.