Bug 1418829

Summary: Improve tests
Product: [Fedora] Fedora Reporter: Jun Aruga <jaruga>
Component: rubygem-cucumber-coreAssignee: Jun Aruga <jaruga>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: vondruch
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: rubygem-cucumber-core-1.5.0-2 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-02-03 12:48:47 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Patch to improve tests none

Description Jun Aruga 2017-02-02 20:14:16 UTC
Created attachment 1247225 [details]
Patch to improve tests

Description of problem:

Right now cucumber-core's tests are run by expecting some errors by
"rspec spec | grep '317 examples, 14 failures'".
This logic might have been reliable for a long time.

However it might be better not to use pipe if possible,
because we can see the result of tests from STDOUT in build.log
I would upload you a patch for that.
I like it will be merged.

Version-Release number of selected component (if applicable):
rubygem-cucumber-core-1.5.0-1

Comment 1 Jun Aruga 2017-02-02 20:17:44 UTC
I checked below things.

License check: ok
rpmlint check: ok
Install check: ok

Comment 2 Vít Ondruch 2017-02-03 09:09:16 UTC
LGTM, thx. I approved you ACL, so feel free to apply the patch.

Comment 3 Jun Aruga 2017-02-03 12:48:47 UTC
Applied the patch to rawhide!