Bug 1418903

Summary: [GDEPLOY+GANESHA] Adding a node to already existing ganesha cluster is failing with Gdeploy
Product: [Red Hat Storage] Red Hat Gluster Storage Reporter: Manisha Saini <msaini>
Component: gdeployAssignee: Sachidananda Urs <surs>
Status: CLOSED ERRATA QA Contact: Manisha Saini <msaini>
Severity: unspecified Docs Contact:
Priority: urgent    
Version: rhgs-3.2CC: amukherj, rcyriac, rhinduja, rhs-bugs, smohan, storage-qa-internal
Target Milestone: ---   
Target Release: RHGS 3.2.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: gdeploy-2.0.1-11 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-03-23 05:09:51 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1351528    

Description Manisha Saini 2017-02-03 04:50:59 UTC
Description of problem:

Adding node to already existing 4 node ganesha cluster is failing with Gdeploy


Version-Release number of selected component (if applicable):
# rpm -qa | grep gdeploy
gdeploy-2.0.1-9.el7rhgs.noarch


How reproducible:
Consistently

Steps to Reproduce:
1.Create a 4 Node ganesha cluster.Enable ganesha on it
2.Add 1 more node to existing 4 node ganesha cluster via gdeploy

# cat add_node.conf 
[hosts]
dhcp46-87.lab.eng.blr.redhat.com
dhcp46-96.lab.eng.blr.redhat.com
dhcp46-112.lab.eng.blr.redhat.com
dhcp47-41.lab.eng.blr.redhat.com

[nfs-ganesha]
action=add-node
nodes=dhcp46-109.lab.eng.blr.redhat.com
vip=10.70.44.157

========================================

# gdeploy  -c add_node.conf 

Error: The number of cluster_nodes provided and VIP given doesn't match. Exiting!
Traceback (most recent call last):
  File "/usr/bin/gdeploy", line 228, in <module>
    main(sys.argv[1:])
  File "/usr/bin/gdeploy", line 207, in main
    call_features()
  File "/usr/lib/python2.7/site-packages/gdeploylib/call_features.py", line 36, in call_features
    map(get_feature_dir, Global.sections)
  File "/usr/lib/python2.7/site-packages/gdeploylib/call_features.py", line 83, in get_feature_dir
    section_dict, yml = feature_call(section_dict)
  File "/usr/lib/python2.7/site-packages/gdeployfeatures/nfs_ganesha/nfs_ganesha.py", line 36, in nfs_ganesha_add_node
    vips, vip_list = get_host_vips(section_dict, new_nodes)
  File "/usr/lib/python2.7/site-packages/gdeployfeatures/nfs_ganesha/nfs_ganesha.py", line 110, in get_host_vips
    self.cleanup_and_quit()
NameError: global name 'self' is not defined

====================================

Actual results:
Adding Node to existing cluster Fails via Gdeploy

Expected results:
Adding Node to existing cluster should be successful via gdeploy

Additional info:

Comment 2 Sachidananda Urs 2017-02-12 04:10:44 UTC
Commit: https://github.com/gluster/gdeploy/commit/f30287e2 should fix the issue.

Comment 3 Manisha Saini 2017-02-16 16:13:55 UTC
Verified this bug on gdeploy-2.0.1-11.el7rhgs.noarch

#add_node.conf
[hosts]
dhcp46-87.lab.eng.blr.redhat.com
dhcp46-96.lab.eng.blr.redhat.com
dhcp46-112.lab.eng.blr.redhat.com
dhcp47-41.lab.eng.blr.redhat.com
dhcp47-126.lab.eng.blr.redhat.com

[peer]
action=probe

[clients]
action=mount
volname=gluster_shared_storage
hosts=dhcp47-126.lab.eng.blr.redhat.com
fstype=glusterfs
client_mount_points=/var/run/gluster/shared_storage/

[nfs-ganesha]
action=add-node
cluster_nodes=dhcp46-87.lab.eng.blr.redhat.com,dhcp46-96.lab.eng.blr.redhat.com,dhcp46-112.lab.eng.blr.redhat.com,dhcp47-41.lab.eng.blr.redhat.com
nodes=dhcp47-126.lab.eng.blr.redhat.com
vip=10.70.44.157



As with this fix build,adding a node to existing cluster is successful,Hence moving this bug to verified state.

Comment 5 errata-xmlrpc 2017-03-23 05:09:51 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHEA-2017-0482.html