Bug 141943
| Summary: | 2 * missing return statements | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | David Binderman <dcb314> |
| Component: | gnome-utils | Assignee: | Marco Pesenti Gritti <mpg> |
| Status: | CLOSED UPSTREAM | QA Contact: | |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 3 | ||
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2005-01-10 12:32:15 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
The first is already fixed upstream, the second reported as http://bugzilla.gnome.org/show_bug.cgi?id=163555 |
Description of problem: I just tried to compile package gnome-utils-2.8.0-5 from Redhat Fedora Core 3. The compiler said 1. gtk.c(1609): warning #117: non-void function "check_for_localized_numeric_point" should return a value The source code is tatic gboolean check_for_localized_numeric_point(int keyval) { gchar outbuf[10]; /* Minumum size 6. */ gunichar ch; ch = gdk_keyval_to_unicode(keyval); g_return_if_fail(g_unichar_validate(ch)); Suggest code re-work to ensure rubbish is not returned to the caller. 2. gdict-applet.c(233): warning #1011: missing return statement at end of non-void function "destroy_applet" The source code is static gboolean destroy_applet (GtkWidget *widget, gpointer data) { GDictApplet *applet = data; if (applet->about_dialog) gtk_widget_destroy (applet->about_dialog); gtk_widget_destroy (applet->button_widget); gtk_widget_destroy (applet->box); gtk_widget_destroy (applet->entry_widget); gtk_widget_destroy (applet->applet_widget); } Suggest add return statement at the end of the routine. Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info: