Bug 1419841
| Summary: | perl-Compress-Raw-Zlib-2.071-1.fc26 FTBFS: deflateParams() tests in t/02zlib.t fail with zlib ≥ 1.2.9 | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Petr Pisar <ppisar> |
| Component: | perl-Compress-Raw-Zlib | Assignee: | Petr Pisar <ppisar> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | jplesnik, paul, perl-devel |
| Target Milestone: | --- | Keywords: | Patch |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | perl-Compress-Raw-Zlib-2.071-2.fc26 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-02-07 14:44:44 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1420326 | ||
|
Description
Petr Pisar
2017-02-07 08:46:16 UTC
From zlib changelog:
Changes in 1.2.9 (31 Dec 2016)
- Assure that deflateParams() will not switch functions mid-block
The test does:
ok(($x, $err) = new Compress::Raw::Zlib::Deflate(
-AppendOutput => 1,
-Level => Z_DEFAULT_COMPRESSION,
-Strategy => Z_DEFAULT_STRATEGY)) ;
And then changes the deflate configuration:
# change both Level & Strategy
$status = $x->deflateParams(-Level => Z_BEST_SPEED, -Strategy => Z_HUFFMAN_ONLY, -Bufsize => 1236) ;
cmp_ok $status, '==', Z_OK ;
So it looks like the test checks a feature that is not supported by recent zlib anymore.
I confirm the zlib change was introduced by zlib commit:
commit 7161ad76e2d0ac7de2a6235fcad3b9dfc99e9140
Author: Mark Adler <madler.edu>
Date: Tue Nov 22 23:29:19 2016 -0800
Assure that deflateParams() will not switch functions mid-block.
This alters the specification in zlib.h, so that deflateParams()
will not change any parameters if there is not enough output space
in the event that a block is emitted in order to allow switching
the compression function.
I posted a fix to upstream. |