Bug 1419894
| Summary: | Tests are failing during build | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Lumír Balhar <lbalhar> | ||||||
| Component: | custodia | Assignee: | Simo Sorce <ssorce> | ||||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | unspecified | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | 26 | CC: | cheimes, mhroncok, ssorce | ||||||
| Target Milestone: | --- | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2017-10-30 07:51:56 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
|
Description
Lumír Balhar
2017-02-07 11:04:30 UTC
Ok, I've found the reason. The reason is that old version (0.4.3) of python-etcd still depends on separated packages dnspython and dnspython3 but this two packages were merged in upstream to one package dnspython. So, when you install python3-dns, the module is named dnspython instead of dnspython3 which causes that Tox tries to download package dnspython3 and it fails in Koji. The update of python-etcd should solve this issue, but we have to wait until upstream developers make a new release. https://github.com/jplana/python-etcd/issues/208 After that, we can update python-etcd package to the newest version and the custodia to Python 3.6. Have a nice day. This bug appears to have been reported against 'rawhide' during the Fedora 26 development cycle. Changing version to '26'. Created attachment 1260883 [details] Add py36 environment to tox tests Hello. I found out that there is a new version of python-etcd in rawhide and lot of issues were fixed in the newest Custodia. But there is still missing Python 3.6 environment in the %check section which leads to skipping tests under Python 3 in rawhide. Because of tox skips tests with the missing environment, is safe to just add test execution with another Python environment. The patch for a specfile is attached. Koji builds: f27: https://koji.fedoraproject.org/koji/taskinfo?taskID=18249170 f26: https://koji.fedoraproject.org/koji/taskinfo?taskID=18249173 f25: https://koji.fedoraproject.org/koji/taskinfo?taskID=18249177 Have a nice day. Lumír (Based on a conversation with Lumír) I don't think that "tox with non-existing Python version will fail silently with exit code 0" should be used as a feature. I'd suggest use this instead:
tox --sitepackages -e py%{python3_version_nodots} -- --skip-servertests
Created attachment 1261547 [details]
Run tests with appropriate Python 3 version
Yes, Miro is right. I didn't know about 'nodots' macro.
New patch version attached.
Hello.
I see that the issue is solved. From my point of view is better to use standard macro '%{python3_version_nodots}' instead of defining new one '%{python3_tox}' but it is up to you.
Commit: http://pkgs.fedoraproject.org/cgit/rpms/custodia.git/commit/?id=05365a8441751e9fb3d7054b7da21be03f79b4b4
My koji scratch build with running tests: https://koji.fedoraproject.org/koji/taskinfo?taskID=19565848
I don't know why but the build of the package with latest committed changes failed. Could you please try it one more time? It seems that in my scratch build there is everything ok.
Failed build: https://koji.fedoraproject.org/koji/taskinfo?taskID=18924699
Thank you and have a nice day.
Lumír
Fixed in the latest version, closing. Commit: https://src.fedoraproject.org/rpms/custodia/c/10e487b50a165b10f2ca996fb08ca5d413da6b02?branch=f27 |