Bug 1419942
| Summary: | Review Request: perl-HTTP-Thin - Thin Wrapper around HTTP::Tiny to play nice with HTTP::Message | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jitka Plesnikova <jplesnik> |
| Component: | Package Review | Assignee: | Petr Pisar <ppisar> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, ppisar |
| Target Milestone: | --- | Flags: | ppisar:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | perl-HTTP-Thin-0.006-1.fc26 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-02-08 08:26:21 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Jitka Plesnikova
2017-02-07 13:18:52 UTC
URL and Source0 addresses are Ok.
Source archive (SHA-256: c4a78588c194603222b0a6b426e61692189def0ce4a0581791873b8720f79e9e) is original. Ok.
Summary verified from lib/HTTP/Thin.pm. Ok.
Description verified from lib/HTTP/Thin.pm. Ok.
License verified from README, LICENSE, lib/HTTP/Thin.pm. Ok.
No XS code, noarch BuildArch is Ok.
Build dependencies are Ok.
All tests pass. Ok.
$ rpmlint perl-HTTP-Thin.spec ../SRPMS/perl-HTTP-Thin-0.006-1.fc26.src.rpm ../RPMS/noarch/perl-HTTP-Thin-0.006-1.fc26.noarch.rpm
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.
$ rpm -q -lv -p ../RPMS/noarch/perl-HTTP-Thin-0.006-1.fc26.noarch.rpm
drwxr-xr-x 2 root root 0 Feb 7 16:04 /usr/share/doc/perl-HTTP-Thin
-rw-r--r-- 1 root root 3494 Apr 21 2014 /usr/share/doc/perl-HTTP-Thin/CHANGES
-rw-r--r-- 1 root root 399 Apr 21 2014 /usr/share/doc/perl-HTTP-Thin/README
drwxr-xr-x 2 root root 0 Feb 7 16:04 /usr/share/doc/perl-HTTP-Thin/ex
-rw-r--r-- 1 root root 157 Feb 7 16:04 /usr/share/doc/perl-HTTP-Thin/ex/simple.pl
drwxr-xr-x 2 root root 0 Feb 7 16:04 /usr/share/licenses/perl-HTTP-Thin
-rw-r--r-- 1 root root 18352 Apr 21 2014 /usr/share/licenses/perl-HTTP-Thin/LICENSE
-rw-r--r-- 1 root root 1943 Feb 7 16:04 /usr/share/man/man3/HTTP::Thin.3pm.gz
drwxr-xr-x 2 root root 0 Feb 7 16:04 /usr/share/perl5/vendor_perl/HTTP
-rw-r--r-- 1 root root 2884 Apr 21 2014 /usr/share/perl5/vendor_perl/HTTP/Thin.pm
Files layout and permissions are Ok.
$ rpm -q --requires -p ../RPMS/noarch/perl-HTTP-Thin-0.006-1.fc26.noarch.rpm | sort -f | uniq -c
1 perl(:MODULE_COMPAT_5.24.1)
1 perl(Class::Method::Modifiers)
1 perl(Hash::MultiValue)
1 perl(HTTP::Response)
1 perl(HTTP::Tiny)
1 perl(parent)
1 perl(Safe::Isa)
1 perl(warnings)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.
$ rpm -q --provides -p ../RPMS/noarch/perl-HTTP-Thin-0.006-1.fc26.noarch.rpm | sort -k2
perl(HTTP::Thin) = 0.006
perl-HTTP-Thin = 0.006-1.fc26
Binary provides are Ok.
$ resolvedeps rawhide ../RPMS/noarch/perl-HTTP-Thin-0.006-1.fc26.noarch.rpm
Binary dependencies resolvable. Ok.
Package builds in F26 (https://koji.fedoraproject.org/koji/taskinfo?taskID=17651008). Ok.
Package is in line with Fedora and Perl packaging guidelines.
Resolution: Package APPROVED.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-HTTP-Thin Thank you for the review and the repository. |