Bug 1420042

Summary: RSpec 3 compatibility
Product: [Fedora] Fedora Reporter: Jun Aruga <jaruga>
Component: rubygem-rack-protectionAssignee: Jun Aruga <jaruga>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: mfojtik, vondruch
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: rubygem-rack-protection-1.5.3-4 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-02-08 13:55:41 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
Patch for RSpec3 compatiblity none

Description Jun Aruga 2017-02-07 16:25:07 UTC
Created attachment 1248455 [details]
Patch for RSpec3 compatiblity

Description of problem:

The package is using RSpec2 for tests.
However actually RSpec3 might be better.

So, I uploaded a patch for that.

Latest upstream rack-protection was being merged to sinatra as version 2 beta.
And it is using RSpec3 for tests.
But there is no good patch for our spec file.
So, I created a patch by myself as modification is simple.

Version-Release number of selected component (if applicable):
rubygem-rack-protection-1.5.3-3

I like it will be merged.

Comment 1 Jun Aruga 2017-02-07 16:27:49 UTC
I checked below things.

- License check: ok
- rpmlint check: ok
- Install check: ok

Comment 2 Vít Ondruch 2017-02-08 13:19:18 UTC
I noticed there is a typo in .spec file: s/proection/protection/

Otherwise the patch looks good. I approved your ACL, so feel free to apply the patch.

Comment 3 Jun Aruga 2017-02-08 13:55:41 UTC
Thanks!
I applied fixing the typo, and doing rebase.