Bug 1420205
Summary: | For console device, default value of append attribute is not consistent with the document | ||
---|---|---|---|
Product: | Red Hat Enterprise Linux 7 | Reporter: | yalzhang <yalzhang> |
Component: | libvirt | Assignee: | Peter Krempa <pkrempa> |
Status: | CLOSED ERRATA | QA Contact: | Jingjing Shao <jishao> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | 7.3 | CC: | chhu, dcallagh, jishao, jracek, jstancek, pkrempa, rbalakri, xuzhang |
Target Milestone: | rc | ||
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | libvirt-3.1.0-1.el7 | Doc Type: | If docs needed, set a value |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2017-08-01 17:21:45 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
yalzhang@redhat.com
2017-02-08 06:57:19 UTC
The default value is treated differently when we use virtlogd instead of the default backend where ommiting the argument would by default truncate the file. Fixed upstream: commit 215a8a976466117104d216f1f336c2c3ad51d010 Author: Peter Krempa <pkrempa> Date: Wed Mar 1 18:15:05 2017 +0100 qemu: command: Truncate the chardev logging file even if append is not present Our documentation states that the chardev logging file is truncated unless append='on' is specified. QEMU also behaves the same way and truncates the file unless we provide the argument. The new virlogd implementation did not honor if the argument was missing and continued to append to the file. Truncate the file even when the 'append' attribute is not present to behave the same with both implementations and adhere to the docs. I'm seeing 2 issues that might be consequence of this change, strangely enough only on powerpc: 1. Bug 1437501 - avc: denied { unlink } for pid=11477 comm="virtlogd" scontext=system_u:system_r:virtlogd_t:s0-s0:c0.c1023 tcontext=system_u:object_r:tmp_t:s0 2. it breaks guest log monitor/uploader in Beaker core task /distribution/virt/install. Daemon which monitors guest console log is left with fd, that's no longer getting any updates. Guests are installed via virt-install, which generates XML automatically. Is there a way to restore back append behaviour that is backwards compatible up to RHEL5? Created a separate BZ for issue 2 mentioned in comment #5. https://bugzilla.redhat.com/show_bug.cgi?id=1441751 Verify this bug as below # rpm -q libvirt libvirt-3.2.0-3.el7.x86_64 # virsh dumpxml V | grep serial -A5 <serial type='file'> <source path='/var/log/libvirt/vm-serial.log'/> <target port='0'/> <alias name='serial0'/> </serial> <console type='file'> <source path='/var/log/libvirt/vm-serial.log'/> <target type='serial' port='0'/> <alias name='serial0'/> </console> # ll /var/log/libvirt/vm-serial.log ls: cannot access /var/log/libvirt/vm-serial.log: No such file or directory # virsh start V Domain V started # cat /var/log/libvirt/vm-serial.log .... Red Hat Enterprise Linux Server 7.4 Beta (Maipo) Kernel 3.10.0-611.el7.x86_64 on an x86_64 # virsh destroy V Domain V destroyed # virsh start V Domain V started # cat /var/log/libvirt/vm-serial.log ..... Red Hat Enterprise Linux Server 7.4 Beta (Maipo) Kernel 3.10.0-611.el7.x86_64 on an x86_64 The result is as expected Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHEA-2017:1846 Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHEA-2017:1846 |