Bug 1420374
| Summary: | Review Request: php-phpunit-php-code-coverage5 - PHP code coverage information | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Remi Collet <fedora> | ||||
| Component: | Package Review | Assignee: | Randy Barlow <randy> | ||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | fedora, package-review, randy | ||||
| Target Milestone: | --- | Flags: | randy:
fedora-review+
|
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2017-03-06 16:43:23 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 1420381, 1420384 | ||||||
| Attachments: |
|
||||||
|
Description
Remi Collet
2017-02-08 14:29:23 UTC
Update to 5.0.1 Spec: https://raw.githubusercontent.com/remicollet/remirepo/b258d9ac5d95927658f06a3921b3361cd923ed9f/php/phpunit/php-phpunit-php-code-coverage5/php-phpunit-php-code-coverage5.spec Srpm: http://rpms.remirepo.net/SRPMS/php-phpunit-php-code-coverage5-5.0.1-1.remi.src.rpm Update to 5.0.2 Spec: https://raw.githubusercontent.com/remicollet/remirepo/35eebaffe6a0f1cf5d8b92c7a0fbdfc1c433de81/php/phpunit/php-phpunit-php-code-coverage5/php-phpunit-php-code-coverage5.spec Srpm: http://rpms.remirepo.net/SRPMS/php-phpunit-php-code-coverage5-5.0.2-1.remi.src.rpm Hello Remi! Here are some things I think we need to fix: The package seems to have bundled bootstrap, jquery, other js, fonts, and css. I think the fonts and css are in the "optional" category, but the javascript stuff would count as a bundled library I think. Recommendation: Either declare that your package provides these bundled, or symlink those packages. I think the syntax for declaring bundled libs is something like: Provides: bundled(js-jquery) == VERSION (or does the == VERSION go inside the bundled()? Not sure…) Also, does this package need to depend on php-pcre? Hi Randy, thanks for your catches. > Also, does this package need to depend on php-pcre? "pcre" is only required for tests (fedora-review run phpcompatinfo on the full sources tree, sometime have to run it manually on "src" and "tests" directory separately). Unbundle .ttf file + provide bundled(xxx) + fix license tag => https://git.io/vyn9B Spec: https://raw.githubusercontent.com/remicollet/remirepo/0082c5854eb46245c1dc8d421ef3b7f83e2b4d26/php/phpunit/php-phpunit-php-code-coverage5/php-phpunit-php-code-coverage5.spec Srpm: http://rpms.remirepo.net/SRPMS/php-phpunit-php-code-coverage5-5.0.2-2.remi.src.rpm Created attachment 1260254 [details]
review.txt
Approved, with one small thing you should fix before submitting to Koji:
There's a small typo in the License: field: s/ans/and/
Nice work!
Thanks for the review! Can you please set the global "fedora-review" flag to + ? (the review+ on attachement is not enough for pkgdb ;) Apologies - I hadn't realized that there was a review flag on attachments and thought I was +'ing the overall review! Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/php-phpunit-php-code-coverage5 > There's a small typo in the License: field: s/ans/and/
good catch. typo fixed (with 5.0.3 update, build in F26+)
|