Bug 1420378
| Summary: | Review Request: php-phpunit-mock-objects4 - Mock Object library for PHPUnit | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Remi Collet <fedora> | ||||||||
| Component: | Package Review | Assignee: | Shawn Iwinski <shawn> | ||||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||
| Severity: | medium | Docs Contact: | |||||||||
| Priority: | medium | ||||||||||
| Version: | rawhide | CC: | fedora, package-review, shawn | ||||||||
| Target Milestone: | --- | Flags: | shawn:
fedora-review+
|
||||||||
| Target Release: | --- | ||||||||||
| Hardware: | All | ||||||||||
| OS: | Linux | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2017-04-01 17:00:28 UTC | Type: | --- | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Bug Depends On: | 1428912 | ||||||||||
| Bug Blocks: | 1420381 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Remi Collet
2017-02-08 14:31:53 UTC
Updated to 4.0.1 Spec: https://raw.githubusercontent.com/remicollet/remirepo/d5483e903e9f49e3efad195c150110bb8e096a20/php/phpunit/php-phpunit-mock-objects4/php-phpunit-mock-objects4.spec Srpm: http://rpms.remirepo.net/SRPMS/php-phpunit-mock-objects4-4.0.1-1.remi.src.rpm Fix for autoloader: Spec: https://raw.githubusercontent.com/remicollet/remirepo /ef56d4822b27c0602e0f2ff509031b39f8cfdce2/php/phpunit/php-phpunit-mock-objects4/php-phpunit-mock-objects4.spec Srpm: http://rpms.remirepo.net/SRPMS/php-phpunit-mock-objects4-4.0.1-2.remi.src.rpm Since this package installs into "/usr/share/php/PHPUnit6/Framework/MockObject" instead of "/usr/share/php/PHPUnit/Framework/MockObject4", shouldn't this package be named "php-phpunit6-mock-objects"? (In reply to Shawn Iwinski from comment #3) > Since this package installs into > "/usr/share/php/PHPUnit6/Framework/MockObject" instead of > "/usr/share/php/PHPUnit/Framework/MockObject4", shouldn't this package be > named "php-phpunit6-mock-objects"? I choice to install in Phpunit6, as this is used by the phpunit6 package, but for the name I prefer to match the API version of the library. BTW... both make sense... only my idea ;) Created attachment 1262076 [details]
phpcompatinfo-full.log
phpCompatInfo version 5.0.4 DB version 1.17.0 built Jan 24 2017 10:56:54 CET
Created attachment 1262077 [details]
phpcompatinfo-lib.log
phpCompatInfo version 5.0.4 DB version 1.17.0 built Jan 24 2017 10:56:54 CET
Created attachment 1262078 [details] fedora-review.txt Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review --mock-config fedora-rawhide-x86_64 --bug 1420378 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, PHP, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 [!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf %{buildroot} present but not required
Remove EPEL 5 bits after initial import
[!]: Spec file according to URL is the same as in SRPM.
Note: Spec file as given by url is not the same as in SRPM (see
attached diff).
Diffs just turning on bootstrap.
No blockers
===== APPROVED =====
Thanks for the review. New packages requested. Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/php-phpunit-mock-objects4 php-phpunit-mock-objects4-4.0.1-2.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-d605f6d602 php-phpunit-mock-objects4-4.0.1-2.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-d605f6d602 php-phpunit-mock-objects4-4.0.1-2.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. |