Bug 1420448

Created attachment 1248643 [details]
search result from '3 Storage Domains'

DashboardDataServlet takes inventory data out of Engine DB, we should check DashboardDataServlet#lookupInventory method impl.

dashboard.InventoryHelper.getStorageInventoryStatus(DataSource)
 -> dashboard.dao.StorageDomainEngineDao.getStorageInventoryStatus()
  -> SQL: "SELECT id, status FROM storage_domains WHERE storage_domain_type IN (0,1)"

from enum org.ovirt.engine.core.common.businessentities.StorageDomainType:
    Master(0),
    Data(1),
    ISO(2),
    ImportExport(3),
    Image(4),
    Volume(5),
    Unknown(6);

By design, the status cards only summarize/count Master and Data type storage domains.

(In reply to Scott Dickerson from comment #3)
> dashboard.InventoryHelper.getStorageInventoryStatus(DataSource)
>  -> dashboard.dao.StorageDomainEngineDao.getStorageInventoryStatus()
>   -> SQL: "SELECT id, status FROM storage_domains WHERE storage_domain_type
> IN (0,1)"
> 
> from enum org.ovirt.engine.core.common.businessentities.StorageDomainType:
>     Master(0),
>     Data(1),
>     ISO(2),
>     ImportExport(3),
>     Image(4),
>     Volume(5),
>     Unknown(6);
> 
> By design, the status cards only summarize/count Master and Data type
> storage domains.

@Yaniv or Oved, thoughts on this? It's basically an inconsistent UX, where the Storage tab can show many more domains than the dashboard.

I think it's good enough. The rest are less interesting. We can get feedback about it if it bothers anyone. (And we'd be happy to deprecate some of the others anyway - such as ISO and export).
Moran?

I spoke with the rest of the UX/dashboard team about the storage domain card.  The status card only counts master/data SDs because only master/data SDs are included in the storage utilization and heat map charts.

There are few easy options to move forward on:
 1. Do nothing because it is working as designed.
 2. Change the status card's label from "Storage Domains" to "Data Storage Domains" or something similar.
 3. Add a tooltip to the card's label that says something similar to "Only master and data storage domains are counted".
 4. Change the query to return all storage domain types.

And a much more complicated options:
 5. Extend the engine storage search/filter bar to allow specifying the storage domain type (only the storage type is currently supported) and have the status card click only show the SD types that are included in its counts.

Oved, Yaniv, Moran - preferences?

#2 and/or #3 make sense to me.

(In reply to Scott Dickerson from comment #6)
> I spoke with the rest of the UX/dashboard team about the storage domain
> card.  The status card only counts master/data SDs because only master/data
> SDs are included in the storage utilization and heat map charts.
> 
> There are few easy options to move forward on:
>  1. Do nothing because it is working as designed.
>  2. Change the status card's label from "Storage Domains" to "Data Storage
> Domains" or something similar.

Sounds like an easy one, but the link of the search will still show more data.
So, technically it will not solve the issue.
But I'm okay with it.

>  3. Add a tooltip to the card's label that says something similar to "Only
> master and data storage domains are counted".
>  4. Change the query to return all storage domain types.
> 
> And a much more complicated options:
>  5. Extend the engine storage search/filter bar to allow specifying the
> storage domain type (only the storage type is currently supported) and have
> the status card click only show the SD types that are included in its counts.
> 

That's the right solution.
We can open an RFE on that one, question is whether this will ever get prioritized.

Scott - please go with #2 and open a bug on #5. Once you see #5 happens, we'll adjust the queries as well.


> Oved, Yaniv, Moran - preferences?

(In reply to Oved Ourfali from comment #8)
> (In reply to Scott Dickerson from comment #6)
> > I spoke with the rest of the UX/dashboard team about the storage domain
> > card.  The status card only counts master/data SDs because only master/data
> > SDs are included in the storage utilization and heat map charts.
> > 
> > There are few easy options to move forward on:
> >  1. Do nothing because it is working as designed.
> >  2. Change the status card's label from "Storage Domains" to "Data Storage
> > Domains" or something similar.
> 
> Sounds like an easy one, but the link of the search will still show more
> data.
> So, technically it will not solve the issue.
> But I'm okay with it.
> 
> >  3. Add a tooltip to the card's label that says something similar to "Only
> > master and data storage domains are counted".
> >  4. Change the query to return all storage domain types.
> > 
> > And a much more complicated options:
> >  5. Extend the engine storage search/filter bar to allow specifying the
> > storage domain type (only the storage type is currently supported) and have
> > the status card click only show the SD types that are included in its counts.
> > 
> 
> That's the right solution.
> We can open an RFE on that one, question is whether this will ever get
> prioritized.
> 
> Scott - please go with #2 and open a bug on #5. Once you see #5 happens,
> we'll adjust the queries as well.
> 

+1, that would give a good enough answer to the dashboard UX for now.

> 
> > Oved, Yaniv, Moran - preferences?

Please reference BZ1436403 for the request to have a filter term added for Storage Domains to allow filtering based on storage domain type.

Verified in
rhevm-4.1.2-0.1.el7.noarch
ovirt-engine-dashboard-1.1.2-1.el7ev.noarch

The storage inventory card label has been changed from "Storage Domains" to "Data Storage Domains" to emphasize that only data domains are included.