Description of problem:
Hammer does not list more than 20 items when trying to query something with more than 20 items.
Version-Release number of selected component (if applicable):
Satellite 6.2.7
tfm-rubygem-hammer_cli-0.5.1.12-1.el7sat.noarch
How reproducible:
everytime
Steps to Reproduce:
1.Create 21 lifecycle environments
2.list all LCE with hammer
3.--page and --per-page options don't work
Actual results:
// 21 lifecycles in the environment
[root@sat62 ~]# hammer -p redhat lifecycle-environment list --organization-id=1
---|---------|--------
ID | NAME | PRIOR
---|---------|--------
1 | Library |
22 | lfc_21 | Library
21 | lfc_20 | Library
20 | lfc_19 | Library
19 | lfc_18 | Library
18 | lfc_17 | Library
17 | lfc_16 | Library
16 | lfc_15 | Library
15 | lfc_14 | Library
14 | lfc_13 | Library
13 | lfc_12 | Library
12 | lfc_11 | Library
11 | lfc_10 | Library
10 | lfc_09 | Library
9 | lfc_08 | Library
8 | lfc_07 | Library
7 | lfc_06 | Library
6 | lfc_05 | Library
5 | lfc_04 | Library
4 | lfc_03 | Library
---|---------|--------
Page 1 of 2 (use --page and --per-page for navigation)
[root@sat62 ~]#
// It's not possible to see the flags --per-page or --page
[root@sat62 ~]# hammer -p redhat lifecycle-environment list --organization-id=1 --help
Usage:
hammer lifecycle-environment list [OPTIONS]
Options:
--library LIBRARY set true if you want to see only library environments
Possible value(s): 'true', 'false'
--name NAME filter only environments containing this name
--organization ORGANIZATION_NAME Organization name to search by
--organization-id ORGANIZATION_ID organization ID
--organization-label ORGANIZATION_LABEL Organization label to search by
-h, --help print help
[root@sat62 ~]#
// Trying to use --page flag
[root@sat62 ~]# hammer -p redhat lifecycle-environment list --organization-id=1 --page
Error: Unrecognised option '--page'
See: 'hammer lifecycle-environment list --help'
[root@sat62 ~]#
// Trying to use --per-page flag
[root@sat62 ~]# hammer -p redhat lifecycle-environment list --organization-id=1 --per-page
Error: Unrecognised option '--per-page'
See: 'hammer lifecycle-environment list --help'
[root@sat62 ~]#
Expected results:
--page --per-page options should work
Additional info:
The issue is caused by missing search params in the apidoc for lifecycle environment index action. Hammer detects when the pagination options are present and tries to iterate over the pages to get full results. If the options are missing, it assumes there's no pagination. So the issue is server side.
Adding this should fix it:
param_group :search, Api::V2::ApiController
There's multiple resources in Katello's api that seem to be affected (I tried to grep for this param group in the controller files) so fixing this deserves checking the whole API.
Comment 6Satellite Program
2017-03-10 21:16:48 UTC
Description of problem: Hammer does not list more than 20 items when trying to query something with more than 20 items. Version-Release number of selected component (if applicable): Satellite 6.2.7 tfm-rubygem-hammer_cli-0.5.1.12-1.el7sat.noarch How reproducible: everytime Steps to Reproduce: 1.Create 21 lifecycle environments 2.list all LCE with hammer 3.--page and --per-page options don't work Actual results: // 21 lifecycles in the environment [root@sat62 ~]# hammer -p redhat lifecycle-environment list --organization-id=1 ---|---------|-------- ID | NAME | PRIOR ---|---------|-------- 1 | Library | 22 | lfc_21 | Library 21 | lfc_20 | Library 20 | lfc_19 | Library 19 | lfc_18 | Library 18 | lfc_17 | Library 17 | lfc_16 | Library 16 | lfc_15 | Library 15 | lfc_14 | Library 14 | lfc_13 | Library 13 | lfc_12 | Library 12 | lfc_11 | Library 11 | lfc_10 | Library 10 | lfc_09 | Library 9 | lfc_08 | Library 8 | lfc_07 | Library 7 | lfc_06 | Library 6 | lfc_05 | Library 5 | lfc_04 | Library 4 | lfc_03 | Library ---|---------|-------- Page 1 of 2 (use --page and --per-page for navigation) [root@sat62 ~]# // It's not possible to see the flags --per-page or --page [root@sat62 ~]# hammer -p redhat lifecycle-environment list --organization-id=1 --help Usage: hammer lifecycle-environment list [OPTIONS] Options: --library LIBRARY set true if you want to see only library environments Possible value(s): 'true', 'false' --name NAME filter only environments containing this name --organization ORGANIZATION_NAME Organization name to search by --organization-id ORGANIZATION_ID organization ID --organization-label ORGANIZATION_LABEL Organization label to search by -h, --help print help [root@sat62 ~]# // Trying to use --page flag [root@sat62 ~]# hammer -p redhat lifecycle-environment list --organization-id=1 --page Error: Unrecognised option '--page' See: 'hammer lifecycle-environment list --help' [root@sat62 ~]# // Trying to use --per-page flag [root@sat62 ~]# hammer -p redhat lifecycle-environment list --organization-id=1 --per-page Error: Unrecognised option '--per-page' See: 'hammer lifecycle-environment list --help' [root@sat62 ~]# Expected results: --page --per-page options should work Additional info: