Bug 1420678

Would it be possible for you to let it run under Valgrind for a while and attach the logs?

can try, any special settings you want me to apply?

sassmann@w541:~ > valgrind --leak-check=yes /usr/libexec/goa-daemon
[...]
==6692== LEAK SUMMARY:
==6692==    definitely lost: 6,516,824 bytes in 283,335 blocks
==6692==    indirectly lost: 132,452,180 bytes in 4,674,664 blocks
==6692==      possibly lost: 20,748 bytes in 609 blocks
==6692==    still reachable: 260,911 bytes in 3,601 blocks
==6692==                       of which reachable via heuristic:
==6692==                         length64           : 3,008 bytes in 53 blocks
==6692==                         newarray           : 1,984 bytes in 44 blocks
==6692==         suppressed: 0 bytes in 0 blocks
==6692== Reachable blocks (those to which a pointer was found) are not shown.
==6692== To see them, rerun with: --leak-check=full --show-leak-kinds=all
==6692==
==6692== For counts of detected and suppressed errors, rerun with: -v
==6692== ERROR SUMMARY: 53 errors from 53 contexts (suppressed: 0 from 0)

At that point goa-daemon already consumed 1,2GB of RAM.

Created attachment 1259485 [details]
full valgrind log

(In reply to Stefan Assmann from comment #3)

Thanks for those logs!

> sassmann@w541:~ > valgrind --leak-check=yes /usr/libexec/goa-daemon

Next time, it won't hurt to throw in --track-origins=yes with the -debuginfo sub-package installed.

I posted a patch on the upstream bug. I expect that it should cut the leak down by quite a bit.

(In reply to Stefan Assmann from comment #0)
> Description of problem:
> Just checked what applications are consuming the most RAM on my machine and
> goa-daemon is the top on, although I'm not using any gnome online accounts
> at all.

Do you happen to have a Kerberos ticket?

(In reply to Debarshi Ray from comment #5)
> (In reply to Stefan Assmann from comment #3)
> 
> Thanks for those logs!
> 
> > sassmann@w541:~ > valgrind --leak-check=yes /usr/libexec/goa-daemon
> 
> Next time, it won't hurt to throw in --track-origins=yes with the -debuginfo
> sub-package installed.

Actually I tried to install all required debuginfo with
# debuginfo-install gnome-online-accounts
if that doesn't catch all dependencies I'm not sure what package I should install manually.

 
> I posted a patch on the upstream bug. I expect that it should cut the leak
> down by quite a bit.

Thanks! Got a link to the patch so I can test it and run valgrind again?

> (In reply to Stefan Assmann from comment #0)
> > Description of problem:
> > Just checked what applications are consuming the most RAM on my machine and
> > goa-daemon is the top on, although I'm not using any gnome online accounts
> > at all.
> 
> Do you happen to have a Kerberos ticket?

Yes, indeed.

(In reply to Stefan Assmann from comment #6)
> (In reply to Debarshi Ray from comment #5)
>> Next time, it won't hurt to throw in --track-origins=yes with the -debuginfo
>> sub-package installed.
> 
> Actually I tried to install all required debuginfo with
> # debuginfo-install gnome-online-accounts
> if that doesn't catch all dependencies I'm not sure what package I should
> install manually.

That should have been enough. I don't know what went wrong.

> > I posted a patch on the upstream bug. I expect that it should cut the leak
> > down by quite a bit.
> 
> Thanks! Got a link to the patch so I can test it and run valgrind again?

It's on the upstream GNOME bug linked from this one:
https://bug779548.bugzilla-attachments.gnome.org/attachment.cgi?id=347162

>> Do you happen to have a Kerberos ticket?
> 
> Yes, indeed.

Ok. That means you are using gnome-online-accounts to some extent. I was worried that goa-daemon was silently chewing memory even when there were no accounts whatsoever.

You made me curious, what does gnome-online-accounts do when I kinit?
Running a version of gnome-online-accounts with your patch applied under valgrind now, let's see what happens.

(In reply to Stefan Assmann from comment #8)
> You made me curious, what does gnome-online-accounts do when I kinit?

It is primarily meant to act as a GUI counterpart of the krb5-workstation command line utilities. So, if you use it to get a Kerberos ticket, instead of kinit, and choose to save your password, it will try its best to ensure that you always have a ticket. If possible, it will renew the ticket, or it will get a new one.

That won't happen if you use kinit to get your ticket. However, goa-daemon will still detect it and show it in the UI so that its world view continues to match that of krb5-workstation's.

Created attachment 1261542 [details]
second valgrind log

New valgrind log with patched goa-daemon, now with proper debuginfo as well.

gnome-online-accounts-3.22.5-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-fb14d710bf

gnome-online-accounts-3.20.7-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-67391b57d7

gnome-online-accounts-3.20.7-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-67391b57d7

gnome-online-accounts-3.22.5-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-fb14d710bf

gnome-online-accounts-3.22.5-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

gnome-online-accounts-3.20.7-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

*** Bug 1269873 has been marked as a duplicate of this bug. ***