Bug 1420730

Summary:	Review Request: perl-Devel-Confess - Include stack traces on all warnings and errors
Product:	[Fedora] Fedora	Reporter:	Jitka Plesnikova <jplesnik>
Component:	Package Review	Assignee:	Petr Pisar <ppisar>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, ppisar
Target Milestone:	---	Flags:	ppisar: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-Devel-Confess-0.009003-1.fc26	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-02-10 09:16:34 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jitka Plesnikova 2017-02-09 12:16:36 UTC

Spec URL: https://jplesnik.fedorapeople.org/perl-Devel-Confess/perl-Devel-Confess.spec
SRPM URL: https://jplesnik.fedorapeople.org/perl-Devel-Confess/perl-Devel-Confess-0.009003-1.fc26.src.rpm

Description:
This module is meant as a debugging aid. It can be used to make a script
complain loudly with stack backtraces when warn()ing or die()ing. Unlike
other similar modules (e.g. Carp::Always), stack traces will also be
included when exception objects are thrown.

Fedora Account System Username: jplesnik

Comment 1 Petr Pisar 2017-02-09 15:17:17 UTC

URL and Source0 addresses are Ok.
Source archive (SHA-256: 21a47e5315ae2e19be98244046f4c579769d8caaf2a367d6a6727cb64f47ab43) is original. Ok.
Summary verified from lib/Devel/Confess.pm. Ok.
Description verified from lib/Devel/Confess.pm. Ok.
License verified from README, lib/Devel/Confess.pm, Makefile.PL. Ok.
No XS code, noarch BuildArch is Ok.

TODO: I recommend to comment dependencies on UNIVERSAL::can and UNIVERSAL::isa are optional for test.

All tests pass. Ok.

$ rpmlint perl-Devel-Confess.spec ../SRPMS/perl-Devel-Confess-0.009003-1.fc26.src.rpm ../RPMS/noarch/perl-Devel-Confess-0.009003-1.fc26.noarch.rpm 
perl-Devel-Confess.src: W: spelling-error %description -l en_US backtraces -> backtracks, back traces, back-traces
perl-Devel-Confess.src: W: spelling-error %description -l en_US ing -> ING, inf, in
perl-Devel-Confess.noarch: W: spelling-error %description -l en_US backtraces -> backtracks, back traces, back-traces
perl-Devel-Confess.noarch: W: spelling-error %description -l en_US ing -> ING, inf, in
2 packages and 1 specfiles checked; 0 errors, 4 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-Devel-Confess-0.009003-1.fc26.noarch.rpm 
drwxr-xr-x    2 root    root                        0 Feb  9 16:11 /usr/share/doc/perl-Devel-Confess
-rw-r--r--    1 root    root                     5268 Nov 18 21:41 /usr/share/doc/perl-Devel-Confess/Changes
-rw-r--r--    1 root    root                     6422 Nov 18 21:41 /usr/share/doc/perl-Devel-Confess/README
-rw-r--r--    1 root    root                     3846 Feb  9 16:11 /usr/share/man/man3/Devel::Confess.3pm.gz
-rw-r--r--    1 root    root                     1508 Feb  9 16:11 /usr/share/man/man3/Devel::Confess::Builtin.3pm.gz
drwxr-xr-x    2 root    root                        0 Feb  9 16:11 /usr/share/perl5/vendor_perl/Devel
drwxr-xr-x    2 root    root                        0 Feb  9 16:11 /usr/share/perl5/vendor_perl/Devel/Confess
-rw-r--r--    1 root    root                    19155 Nov 18 21:41 /usr/share/perl5/vendor_perl/Devel/Confess.pm
-rw-r--r--    1 root    root                     3592 Nov 18 21:41 /usr/share/perl5/vendor_perl/Devel/Confess/Builtin.pm
-rw-r--r--    1 root    root                     1780 Sep  7 00:22 /usr/share/perl5/vendor_perl/Devel/Confess/Source.pm
-rw-r--r--    1 root    root                     4894 Nov 17 01:07 /usr/share/perl5/vendor_perl/Devel/Confess/_Util.pm
File layout and permissions is Ok.

$ rpm -q --requires -p ../RPMS/noarch/perl-Devel-Confess-0.009003-1.fc26.noarch.rpm | sort -f | uniq -c
      1 perl(:MODULE_COMPAT_5.24.1)
      1 perl(:VERSION) >= 5.6.0
      1 perl(Carp)
      1 perl(Carp::Heavy)
      1 perl(Config)
      1 perl(Data::Dumper)
      1 perl(Devel::Confess::_Util)
      1 perl(Exporter)
      1 perl(overload)
      1 perl(Scalar::Util)
      1 perl(strict)
      1 perl(Symbol)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -q --provides -p ../RPMS/noarch/perl-Devel-Confess-0.009003-1.fc26.noarch.rpm | sort -f | uniq -c
      1 perl(Devel::Confess) = 0.009003
      1 perl(Devel::Confess::Builtin) = 0.009003
      1 perl(Devel::Confess::Source)
      1 perl(Devel::Confess::_Util)
      1 perl-Devel-Confess = 0.009003-1.fc26
Binary provides are Ok.

$ resolvedeps rawhide ../RPMS/noarch/perl-Devel-Confess-0.009003-1.fc26.noarch.rpm
Binary dependencies resolvable. Ok.

Package builds in F26 (https://koji.fedoraproject.org/koji/taskinfo?taskID=17692127). Ok.

Package is in line with Fedora and Perl packaging guidelines.

Please consider fixing the `TODO' item before building this package.
Resolution: Package APPROVED.

Comment 2 Gwyn Ciesla 2017-02-09 16:28:33 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Devel-Confess

Comment 3 Jitka Plesnikova 2017-02-10 09:16:34 UTC

Thank you for the review and the repository.