Bug 1420992 (CVE-2017-2622)

Summary: CVE-2017-2622 openstack-mistral: /var/log/mistral/ is world readable
Product: [Other] Security Response Reporter: Summer Long <slong>
Component: vulnerabilityAssignee: Red Hat Product Security <security-response-team>
Status: CLOSED ERRATA QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: unspecifiedCC: aortega, apevec, ayoung, chrisw, cvsbot-xmlrpc, dmatthew, jjoyce, jschluet, kbasil, lhh, lpeer, markmc, mburns, rbryant, rhos-maint, sbaker, sclewis, security-response-team, shardy, slinaber, srevivo, tdecacqu, tvignaud, zbitter
Target Milestone: ---Keywords: Security
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
An accessibility flaw was found in the OpenStack Workflow (mistral) service where a service log directory was improperly made world readable. A malicious system user could exploit this flaw to access sensitive information.
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-06-28 23:46:42 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1421000, 1421001, 1422267    
Bug Blocks: 1422332    

Description Summer Long 2017-02-10 05:03:14 UTC
The directory /var/log/mistral is world readable and contains log files that are readable, which can result in the exposure of sensitive information. The 'other readable/execute' bits need to be removed from the /var/log/mistral directory:

[stack@instack ~]$ ls -la /var/log/mistral
total 2288
drwxr-xr-x.  2 mistral mistral    4096 Feb  9 01:07 .
drwxr-xr-x. 31 root    root       4096 Feb  9 01:02 ..
-rw-r--r--.  1 mistral mistral  112623 Feb  9 20:09 api.log
-rw-r--r--.  1 mistral mistral 1829883 Feb  9 20:09 engine.log
-rw-r--r--.  1 mistral mistral  383889 Feb  9 20:09 executor.log

Comment 1 Summer Long 2017-02-10 05:07:20 UTC
Acknowledgments:

Name: Hans Feldt (Ericsson)

Comment 4 Summer Long 2017-02-14 22:30:31 UTC
Created openstack-mistral tracking bugs for this issue:

Affects: openstack-rdo [bug 1422267]

Comment 5 errata-xmlrpc 2017-06-28 14:57:42 UTC
This issue has been addressed in the following products:

  Red Hat OpenStack Platform 10.0 (Newton)

Via RHSA-2017:1584 https://access.redhat.com/errata/RHSA-2017:1584

Comment 6 Dougal Matthews 2019-11-21 10:54:45 UTC
While this has been resolved in Mistral, I noticed that when debug logging is enabled heatclient does log the passwords. They then show up in the Mistral logs. Is this something we need to look into or can we ignore DEBUG messages?

Comment 7 Dougal Matthews 2019-11-21 12:39:05 UTC
(In reply to Dougal Matthews from comment #6)
> While this has been resolved in Mistral, I noticed that when debug logging
> is enabled heatclient does log the passwords. They then show up in the
> Mistral logs. Is this something we need to look into or can we ignore DEBUG
> messages?

Apologise. This wording is a bit confusing. I realise this CVE is specific to the logs being world readable. I have put in some time to mask the passwords in Mistral logs, so they are now replaced with *** in the logs. This work has merged upstream in master, train, stein and rocky. This seems to be working well with the exception of logging done by heatclient which does a DEBUG log of the passwords. Is this something we can consider okay or should we look into it? I believe we don't recommend running with debug logging normally.

Comment 8 Summer Long 2019-11-24 23:34:48 UTC
Hi Dougal, this is the older CVE. The one matching the bug: https://bugs.launchpad.net/tripleo/+bug/1850843
is here: https://bugzilla.redhat.com/show_bug.cgi?id=1768731
DEBUG logging will only be a hardening issue if the regression to world-readable has been fixed.
thanks, Summer

Comment 9 Dougal Matthews 2019-11-28 08:31:41 UTC
Thanks, sorry, I got confused. I'll move to the correct BZ.