Bug 1421089

Summary:	cockpit-ovirt fails to build due to missing webpack
Product:	[oVirt] cockpit-ovirt	Reporter:	Sandro Bonazzola <sbonazzo>
Component:	Generic	Assignee:	Ryan Barry <rbarry>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Ryan Barry <rbarry>
Severity:	urgent	Docs Contact:
Priority:	unspecified
Version:	---	CC:	bugs, cshao, rbarry
Target Milestone:	ovirt-4.1.1	Keywords:	BuildBlocker, CodeChange, Regression
Target Release:	0.10.7-0.0.13	Flags:	rule-engine: ovirt-4.1+ rule-engine: blocker+ cshao: testing_ack+
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-02-21 18:03:28 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Node	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Sandro Bonazzola 2017-02-10 10:20:22 UTC

Description of problem:
+ make
make[1]: Entering directory `/home/jenkins/workspace/cockpit-ovirt_master_build-artifacts-el7-x86_64/cockpit-ovirt/tmp.repos/BUILD/cockpit-ovirt-0.10.7-0.0.8'
Making all in dashboard
make[2]: Entering directory `/home/jenkins/workspace/cockpit-ovirt_master_build-artifacts-el7-x86_64/cockpit-ovirt/tmp.repos/BUILD/cockpit-ovirt-0.10.7-0.0.8/dashboard'
test -z "" || npm i
npm run build

> cockpit-ovirt-dashboard.7-0.0.8 build /home/jenkins/workspace/cockpit-ovirt_master_build-artifacts-el7-x86_64/cockpit-ovirt/tmp.repos/BUILD/cockpit-ovirt-0.10.7-0.0.8/dashboard
> NODE_ENV=production webpack -p --progress

sh: webpack: command not found

Seen on http://jenkins.ovirt.org/user/sbonazzo/my-views/view/Builders/job/cockpit-ovirt_master_build-artifacts-el7-x86_64/172/artifact/exported-artifacts/mock_logs/mocker-epel-7-x86_64.el7.build-artifacts.sh/build-artifacts.sh.log

Comment 1 Red Hat Bugzilla Rules Engine 2017-02-10 10:20:28 UTC

This bug report has Keywords: Regression or TestBlocker.
Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release. Please resolve ASAP.

Comment 2 Ryan Barry 2017-02-10 14:24:45 UTC

It looks like Vojtech already moved to yarn to build ovirt-engine-nodejs-modules.

We'll need some rearranging (adding yarn.lock, removing dashboard/package.json and vdsm/package.json from autoconf -- we don't publish these to npm anyway, so that's probably ok), then waiting for a new ovirt-engine-nodejs-modules to build.

As an intermediate fix, we can always use ovirt-engine-nodejs-modules from the 4.1 released repository, or revert the repo change in your last patch.

I'm not sure what the repos you switched to are.

Comment 3 Ryan Barry 2017-02-10 16:51:44 UTC

Everything is rearranged, but we still need to wait for a new build of ovirt-engine-nodejs-modules for this to work.

Comment 4 dguo 2017-02-14 03:24:56 UTC

Ryan, 

We QE currently might not familiar how to build the cockpit-ovirt, so could you please help to verify this bug if the ovirt-engine-nodejs-modules is ready.

If yes, I will change the QA contact to you.

Comment 5 Ryan Barry 2017-02-14 06:15:17 UTC

Totally OK with me.

Comment 6 Sandro Bonazzola 2017-02-16 08:33:22 UTC

I understood this affected master only but looks like it's on 4.1 as well: http://jenkins.ovirt.org/job/cockpit-ovirt_4.1_build-artifacts-fc24-x86_64/27/artifact/exported-artifacts/mock_logs/mocker-fedora-24-x86_64.fc24.build-artifacts.sh/build-artifacts.sh.log