Bug 1421138

Summary: Review Request: perl-RDF-Prefixes - Simple way to turn URIs into QNames
Product: [Fedora] Fedora Reporter: Petr Pisar <ppisar>
Component: Package ReviewAssignee: Jitka Plesnikova <jplesnik>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: jplesnik, package-review
Target Milestone: ---Flags: jplesnik: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: perl-RDF-Prefixes-0.005-1.fc26 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-02-13 09:25:18 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1421142    

Description Petr Pisar 2017-02-10 12:27:38 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-RDF-Prefixes/perl-RDF-Prefixes.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-RDF-Prefixes/perl-RDF-Prefixes-0.005-1.fc26.src.rpm
Description:
This Perl module generates pretty prefixes, reducing
"http://purl.org/dc/terms" to "dc" rather than something too generic like like
"ns01", and provides a context for keeping track of name spaces already used,
so that when "http://purl.org/dc/elements/1.1/" is encountered, it won't stomp
on the previous definition of "dc".

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2017-02-10 13:21:04 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-RDF-Prefixes-0.005-1.fc26.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.24.1)
      1 perl(:VERSION) >= 5.10.0
      1 perl(constant)
      1 perl(overload)
      1 perl(strict)
      1 perl(utf8)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-RDF-Prefixes-0.005-1.fc26.noarch.rpm | sort | uniq -c
      1 perl(RDF::Prefixes) = 0.005
      1 perl-RDF-Prefixes = 0.005-1.fc26
Binary provides are Ok.

$ rpmlint ./perl-RDF-Prefixes*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

Rpmlint is ok

The package is good.
Approved.

Comment 2 Gwyn Ciesla 2017-02-10 15:06:54 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-RDF-Prefixes

Comment 3 Petr Pisar 2017-02-13 09:25:18 UTC
Thank you for the review and the repository.