Bug 1421261

Summary:	s/memcached_node_ids/memcache_node_ids
Product:	Red Hat OpenStack	Reporter:	Martin Magr <mmagr>
Component:	openstack-tripleo-heat-templates	Assignee:	Emilien Macchi <emacchi>
Status:	CLOSED NOTABUG	QA Contact:	Arik Chernetsky <achernet>
Severity:	urgent	Docs Contact:
Priority:	unspecified
Version:	10.0 (Newton)	CC:	dsavinea, mburns, rhel-osp-director-maint
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-02-11 21:25:17 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Martin Magr 2017-02-10 18:53:28 UTC

Description of problem:
While deploying plain Ceph cluster I'm facing issue that puppet-tripleo works with variable memcached_node_ips [1], but THT does not provide such variable [2], because it is providing memcache_node_ips variable instead. Though I'm not sure if I'm doing this wrong or OSP-10 is broken.

[1] https://github.com/openstack/puppet-tripleo/search?utf8=%E2%9C%93&q=memcached_node_ips
[2] https://github.com/openstack/tripleo-heat-templates/search?utf8=%E2%9C%93&q=memcached_node_ips
[3] https://github.com/openstack/tripleo-heat-templates/search?utf8=%E2%9C%93&q=memcache_node_ips

Version-Release number of selected component (if applicable):
openstack-tripleo-heat-templates-5.2.0-3.el7ost.noarch
puppet-tripleo-5.5.0-2.el7ost.noarch

Actual results:
[stack@undercloud ~]$ heat deployment-output-show 292f24e9-931f-4a34-a0c2-8fc6971d8fce deploy_stderr
WARNING (shell) "heat deployment-output-show" is deprecated, please use "openstack software deployment output show" instead
exception: connect failed
Error: Could not find data item memcached_node_ips in any Hiera data file and no default supplied at /etc/puppet/modules/tripleo/manifests/profile/base/nova.pp:67 on node overcloud-compute-0.localdomain
Error: Could not find data item memcached_node_ips in any Hiera data file and no default supplied at /etc/puppet/modules/tripleo/manifests/profile/base/nova.pp:67 on node overcloud-compute-0.localdomain

Expected results:
Successful Ceph deployment

Additional info:
User environment file:
[stack@undercloud ~]$ cat monitoring-environment.yaml 
## A Heat environment file which can be used to set up monitoring agents

resource_registry:
  OS::TripleO::Services::SensuClient: /usr/share/openstack-tripleo-heat-templates/puppet/services/monitoring/sensu-client.yaml
  OS::TripleO::Services::CephMon: /usr/share/openstack-tripleo-heat-templates/puppet/services/ceph-mon.yaml
  OS::TripleO::Services::CephOSD: /usr/share/openstack-tripleo-heat-templates/puppet/services/ceph-osd.yaml

parameters:
  ControllerServices:
    - OS::TripleO::Services::CephMon
    - OS::TripleO::Services::SensuClient
  CephStorageServices:
    - OS::TripleO::Services::CephOSD
    - OS::TripleO::Services::SensuClient

parameter_defaults:
  MonitoringRabbitHost: 192.168.66.94
#  MonitoringRabbitPort: 5672
#  MonitoringRabbitUserName: sensu
  MonitoringRabbitPassword: sensu
#  MonitoringRabbitUseSSL: false
#  MonitoringRabbitVhost: "/sensu"
#  SensuClientCustomConfig:
#    api:
#      warning: 10
#      critical: 20
[stack@undercloud ~]$

Comment 3 Dimitri Savineau 2017-02-10 19:48:15 UTC

You can't find memcached_node_ips because this variable is now build dynamically.

https://github.com/openstack/tripleo-heat-templates/blob/stable/newton/network/ports/net_ip_list_map.yaml#L74-L102

So if you have enable memcached service (OS::TripleO::Services::Memcached) it will create memcached_node_ips in hiera (all_nodes.json)


[root@overcloud-controller-0 ~]# hiera service_names |grep memcached
 "memcached",
[root@overcloud-controller-0 ~]# hiera memcached_node_ips
["172.16.2.18", "172.16.2.4", "172.16.2.19"]

Comment 4 Martin Magr 2017-02-11 21:25:17 UTC

ACK, thanks for explanation.