Bug 1421582

Summary:	Review Request: perl-namespace-sweep - Sweep up imported subs in your classes
Product:	[Fedora] Fedora	Reporter:	Ralf Corsepius <rc040203>
Component:	Package Review	Assignee:	Petr Pisar <ppisar>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jplesnik, package-review, ppisar
Target Milestone:	---	Flags:	ppisar: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-namespace-sweep-0.006-1.fc27	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-06-13 12:23:01 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Ralf Corsepius 2017-02-13 07:42:03 UTC

Spec URL: https://corsepiu.fedorapeople.org/packages/perl-namespace-sweep.spec
SRPM URL: https://corsepiu.fedorapeople.org/packages/perl-namespace-sweep-0.006-1.fc26.src.rpm
Description: 
Because Perl methods are just regular subroutines, it's difficult to tell
what's a method and what's just an imported function. As a result, imported
functions can be called as methods on your objects. This pragma will delete
imported functions from your class's symbol table, thereby ensuring that
your interface is as you specified it. However, code inside your module
will still be able to use the imported functions without any problems.

Fedora Account System Username: corsepiu

Comment 1 Petr Pisar 2017-02-23 14:39:40 UTC

URL and Source0 addresses are usable. Ok.
Source archive (SHA-256: de99ce915ab0f93781580e3433d7dc9c2585a2789627173b280c6030ac0b1953) is original. Ok.
Summary verified from lib/namespace/sweep.pm. Ok.
Description verified from lib/namespace/sweep.pm. Ok.
License verified from lib/namespace/sweep.pm, LICENSE, README. Ok.
No XS code, noarch BuildArch is Ok.

TODO: Constrain `perl(ExtUtils::MakeMaker)' dependency with `>= 6.30' (Makefile.PL:7).

FIX: Build-require `perl(overload)' (t/overload.t:10).

All tests pass. Ok.

$ rpmlint perl-namespace-sweep.spec ../SRPMS/perl-namespace-sweep-0.006-1.fc26.src.rpm ../RPMS/noarch/perl-namespace-sweep-0.006-1.fc26.noarch.rpm 
perl-namespace-sweep.spec:29: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 29)
perl-namespace-sweep.src: W: spelling-error %description -l en_US pragma -> pragmatic
perl-namespace-sweep.src:29: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 29)
perl-namespace-sweep.noarch: W: spelling-error %description -l en_US pragma -> pragmatic
2 packages and 1 specfiles checked; 0 errors, 4 warnings.
TODO: Normalize spaces.

$ rpm -q -lv -p ../RPMS/noarch/perl-namespace-sweep-0.006-1.fc26.noarch.rpm 
drwxr-xr-x    2 root    root                        0 Feb 23 15:31 /usr/share/doc/perl-namespace-sweep
-rw-r--r--    1 root    root                      308 Oct 16  2012 /usr/share/doc/perl-namespace-sweep/README
drwxr-xr-x    2 root    root                        0 Feb 23 15:31 /usr/share/licenses/perl-namespace-sweep
-rw-r--r--    1 root    root                    18350 Oct 16  2012 /usr/share/licenses/perl-namespace-sweep/LICENSE
-rw-r--r--    1 root    root                     2733 Feb 23 15:31 /usr/share/man/man3/namespace::sweep.3pm.gz
drwxr-xr-x    2 root    root                        0 Feb 23 15:31 /usr/share/perl5/vendor_perl/namespace
-rw-r--r--    1 root    root                     6670 Oct 16  2012 /usr/share/perl5/vendor_perl/namespace/sweep.pm
File layout and permissions are Ok.

$ rpm -q --requires -p ../RPMS/noarch/perl-namespace-sweep-0.006-1.fc26.noarch.rpm | sort -f | uniq -c
      1 perl(:MODULE_COMPAT_5.24.1)
      1 perl(B::Hooks::EndOfScope) >= 0.09
      1 perl(Carp)
      1 perl(Data::Dumper)
      1 perl(List::Util)
      1 perl(Package::Stash) >= 0.33
      1 perl(Scalar::Util)
      1 perl(strict)
      1 perl(Sub::Identify) >= 0.04
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -q --provides -p ../RPMS/noarch/perl-namespace-sweep-0.006-1.fc26.noarch.rpm | sort -f | uniq -c
      1 perl(namespace::sweep) = 0.006
      1 perl-namespace-sweep = 0.006-1.fc26
Binary provides are Ok.

$ resolvedeps rawhide ../RPMS/noarch/perl-namespace-sweep-0.006-1.fc26.noarch.rpm 
Binary dependencies resolvable. Ok.

Package builds in F26 (https://koji.fedoraproject.org/koji/taskinfo?taskID=18013656). Ok.

Otherwise the package is in line with Fedora and Perl packaging guidelines.
Please correct the `FIX' item and consider fixing all the `TODO' items before building this package.
Resolution: Package APPROVED.

Comment 2 Ralf Corsepius 2017-03-13 16:08:35 UTC

Sorry, Petr, I almost had forgotten about this review request and missed your approval. Thanks.

Comment 3 Gwyn Ciesla 2017-03-13 17:22:34 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-namespace-sweep