Bug 1421602

Summary: Container Review Request: s2i-base - Base image with all the essential libraries and tools for other s2i images
Product: [Fedora] Fedora Reporter: Honza Horak <hhorak>
Component: Package ReviewAssignee: Adam Samalik <asamalik>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: asamalik, package-review
Target Milestone: ---Flags: asamalik: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-03-13 06:23:25 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Honza Horak 2017-02-13 09:00:13 UTC
Dockerfile URL: https://hhorak.fedorapeople.org/s2i-base-docker/Dockerfile
Other files URL: https://hhorak.fedorapeople.org/s2i-base-docker/

Description: 

This container image serves as a base image with all the essential libraries and tools needed for OpenShift language images, namely: ruby, python, perl, nodejs, or php.

Fedora Account System Username: hhorak

Comment 1 Adam Samalik 2017-03-07 16:33:31 UTC
Hey Honza!

I have a question about ENTRYPOINT. You have the following script in there:

#!/bin/bash
exec "$@"

Why are you doing that?

Comment 2 Honza Horak 2017-03-07 16:39:33 UTC
It's remaining piece from SCL enabling trick, so I have removed it.

Comment 3 Adam Samalik 2017-03-07 16:40:39 UTC
Ha! That looks good to me, then!

Comment 4 Gwyn Ciesla 2017-03-07 17:15:53 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/docker/s2i-base