Bug 1421807

Created attachment 1249979 [details]
Patch to remove test with unreliable results

Description of problem:
In Jackcess 2.1.3, there is an "ancient dates" test. In the current specfile, this is hacked up to provide a different set of "expected" results. However, while that hack appears to work against F25 and Rawhide, it fails under some other mock builds, depending on what packages happen to be in the buildroot. In the case of the Base Runtime build, it fails because it gets back the exact results the upstream test is expecting.

Given that this test is clearly unreliable, I'm providing a patch to skip this one to avoid it causing a FTBFS on modular builds. Please either apply this patch to dist-git within two weeks or provide a reason not to do so.

If you also decide to do a rebase to the latest upstream release, please apply this patch as a separate commit *first*. That way, we can reference that git hash when performing our modular build.


Version-Release number of selected component (if applicable):
jackcess-2.1.3-3.fc25

How reproducible:
Every time

Steps to Reproduce:
1. Build jackcess-2.1.3-4.fc25 in the module build service[1]

Actual results:
Tests run: 26, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.841 sec <<< FAILURE! - in com.healthmarketscience.jackcess.DatabaseTest
testAncientDates(com.healthmarketscience.jackcess.DatabaseTest)  Time elapsed: 0.021 sec  <<< FAILURE!
junit.framework.AssertionFailedError: expected:<[1582-10-14, 1582-10-13, 1492-01-09, 1392-01-09]> but was:<[1582-10-15, 1582-10-14, 1492-01-10, 1392-01-10]>
	at com.healthmarketscience.jackcess.DatabaseTest.testAncientDates(DatabaseTest.java:728)

Expected results:
All tests should pass.

Additional info:

[1] Alternately, here is a mock config that can be run locally:

config_opts['root'] = 'fedora-25-base-runtime'
config_opts['target_arch'] = 'x86_64'
config_opts['legal_host_arches'] = ('x86_64',)
config_opts['chroot_setup_cmd'] = 'install bash bzip2 coreutils cpio diffutils fedora-release findutils gawk gcc gcc-c++ grep gzip info make patch redhat-rpm-config rpm-build sed shadow-utils tar unzip util-linux which xz'
config_opts['dist'] = ''  # only useful for --resultdir variable subst
config_opts['extra_chroot_dirs'] = [ '/run/lock', ]
config_opts['releasever'] = ''
config_opts['package_manager'] = 'dnf'

config_opts['yum.conf'] = """
[main]
keepcache=1
debuglevel=2
reposdir=/dev/null
logfile=/var/log/yum.log
retries=20
obsoletes=1
gpgcheck=0
assumeyes=1
syslog_ident=mock
syslog_device=
install_weak_deps=0
metadata_expire=0
mdpolicy=group:primary

# repos

[base-runtime]
name=base-runtime
baseurl=http://kojipkgs.stg.fedoraproject.org/repos/module-base-runtime-master-3/latest/x86_64/
enabled=1

[local-override]
name=local-override
baseurl=file:///home/sgallagh/workspace/baseruntime/repos/override/
enabled=1

"""