Bug 1422145

Summary: Adding disk to a VM in RHV provider, via VM reconfigure, does not activate it
Product: Red Hat CloudForms Management Engine Reporter: Ilanit Stein <istein>
Component: ProvidersAssignee: Moti Asayag <masayag>
Status: CLOSED CURRENTRELEASE QA Contact: Ilanit Stein <istein>
Severity: urgent Docs Contact:
Priority: unspecified    
Version: 5.7.0CC: jfrey, jhardy, obarenbo, oourfali, simaishi
Target Milestone: GAKeywords: Regression, TestOnly, ZStream
Target Release: 5.8.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: rhev
Fixed In Version: 5.8.0.1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1422178 (view as bug list) Environment:
Last Closed: 2017-06-12 16:43:13 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: RHEVM Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1422178    

Description Ilanit Stein 2017-02-14 15:09:40 UTC 
Description of problem:


Version-Release number of selected component (if applicable):
CFME-5.7.1.1.20170206165110_3c42361 & RHV-4.0.5

How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:
Comment 2 CFME Bot 2017-02-14 15:51:33 UTC 
https://github.com/ManageIQ/manageiq/pull/13913
Comment 3 CFME Bot 2017-02-14 16:16:09 UTC 
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/8fdeaad475143da463d3cb88097c09d78e7c3b49

commit 8fdeaad475143da463d3cb88097c09d78e7c3b49
Author:     Moti Asayag <masayag>
AuthorDate: Tue Feb 14 17:22:46 2017 +0200
Commit:     Moti Asayag <masayag>
CommitDate: Tue Feb 14 17:35:27 2017 +0200

    Disks should be added as 'active' in RHV
    
    PR https://github.com/ManageIQ/manageiq/pull/13318 introduced a new
    class to handle disk attachments. A disk should be added to RHV as
    'active' since there is no method to modify it afterward.
    
    DiskAttachmentBuilder class will set the 'active' as the default
    status of the new disk, so any scenario which adds disks (vm
    reconfigure, automation request, provision request) will share the same
    behavior.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1422145

 .../providers/redhat/infra_manager/disk_attachment_builder.rb         | 3 +--
 .../providers/redhat/infra_manager/disk_attachment_builder_spec.rb    | 4 ++--
 .../manageiq/providers/redhat/infra_manager/provision/disk_spec.rb    | 2 +-
 3 files changed, 4 insertions(+), 5 deletions(-)
Comment 5 Ilanit Stein 2017-04-23 11:23:42 UTC 
Verified on CFME-5.8.0.1/RHV-4.0.7

VM reconfigure-> Hot added disk to a VM that already had a bootable disk.
The disk was added & activated as expected.