Bug 1422786

Summary: make insufficient permission errors more visible (especially in connection down)
Product: Red Hat Enterprise Linux 7 Reporter: Vladimir Benes <vbenes>
Component: NetworkManagerAssignee: Beniamino Galvani <bgalvani>
Status: CLOSED ERRATA QA Contact: Desktop QE <desktop-qa-list>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 7.4CC: atragler, bgalvani, fgiudici, lrintel, mleitner, rkhan, sukulkar, thaller
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: NetworkManager-1.8.0-0.4.rc3.el7 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-08-01 09:22:07 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
[PATCH] cli: check for deactivation failures none

Description Vladimir Benes 2017-02-16 09:13:08 UTC 
Description of problem:

[vagrant@dacan NetworkManager-ci]$ sudo nmcli connection down testeth1
Connection 'testeth1' successfully deactivated (D-Bus active path: /org/freedesktop/NetworkManager/ActiveConnection/3)

[vagrant@dacan NetworkManager-ci]$ nmcli connection up testeth1
Error: Connection activation failed: Not authorized to control networking.

[vagrant@dacan NetworkManager-ci]$ nmcli connection down testeth1
Error: 'testeth1' is not an active connection.
Error: no active connection provided.

[vagrant@dacan NetworkManager-ci]$ sudo nmcli connection up testeth1
Connection successfully activated (D-Bus active path: /org/freedesktop/NetworkManager/ActiveConnection/4)

[vagrant@dacan NetworkManager-ci]$ nmcli connection down testeth1
Error: Timeout expired (10 seconds)

^^ This is weird as it timeouts rather than saying you don't have permissions and quitting immediately 


[vagrant@dacan NetworkManager-ci]$ rpm -q NetworkManager
NetworkManager-1.6.3-16765.0770d7e68e.el7.centos.x86_64
 
[vagrant@dacan NetworkManager-ci]$ nmcli general permissions 
PERMISSION                                                 VALUE 
org.freedesktop.NetworkManager.enable-disable-network      no    
org.freedesktop.NetworkManager.enable-disable-wifi         no    
org.freedesktop.NetworkManager.enable-disable-wwan         no    
org.freedesktop.NetworkManager.enable-disable-wimax        no    
org.freedesktop.NetworkManager.sleep-wake                  no    
org.freedesktop.NetworkManager.network-control             auth  
org.freedesktop.NetworkManager.wifi.share.protected        no    
org.freedesktop.NetworkManager.wifi.share.open             no    
org.freedesktop.NetworkManager.settings.modify.system      auth  
org.freedesktop.NetworkManager.settings.modify.own         auth  
org.freedesktop.NetworkManager.settings.modify.hostname    auth  
org.freedesktop.NetworkManager.settings.modify.global-dns  auth  
org.freedesktop.NetworkManager.reload                      auth  
org.freedesktop.NetworkManager.checkpoint-rollback         auth  
org.freedesktop.NetworkManager.enable-disable-statistics   no
Comment 1 Beniamino Galvani 2017-04-13 13:27:37 UTC 
Created attachment 1271434 [details]
[PATCH] cli: check for deactivation failures
Comment 2 Thomas Haller 2017-04-13 13:34:47 UTC 
(In reply to Beniamino Galvani from comment #1)
> Created attachment 1271434 [details]
> [PATCH] cli: check for deactivation failures

lgtm
Comment 3 Beniamino Galvani 2017-04-13 15:22:21 UTC 
Applied to master:

https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=67d144dd1e538cc753cbb581927f4b101726f271

and nm-1-8:

https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?h=nm-1-8&id=9029dabb87dc7e2951c058a2e77a904c900d860c
Comment 5 errata-xmlrpc 2017-08-01 09:22:07 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2017:2299