Bug 1422944

Summary: [LLNL 7.4 Bug] ntp no longer works correctly with multicastclient
Product: Red Hat Enterprise Linux 7 Reporter: Trent D'Hooge <tdhooge>
Component: ntpAssignee: Miroslav Lichvar <mlichvar>
Status: CLOSED CURRENTRELEASE QA Contact: qe-baseos-daemons
Severity: urgent Docs Contact: Mirek Jahoda <mjahoda>
Priority: urgent    
Version: 7.3CC: lpol, mjahoda, psklenar, qe-baseos-daemons, salmy, tdhooge, tgummels, todoleza, toneata, woodard
Target Milestone: rcKeywords: Regression, ZStream
Target Release: 7.4   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: ntp-4.2.6p5-27.el7 Doc Type: Bug Fix
Doc Text:
Prior to this update, the NTP daemon (ntpd) configured as a multicast client was not able to process multicast messages after an association with a multicast server had been created. As a consequence, the multicast client was repeatedly resetting the association with the server and it processed only unicast messages in the initial exchange. With this update, the described bug has been fixed, and the NTP multicast client now works properly in the described scenario.
Story Points: ---
Clone Of:
: 1422973 1427573 (view as bug list) Environment:
Last Closed: 2017-08-28 13:23:24 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1381646, 1427573, 1472751    
Attachments:
Description Flags
Fix regression in multicastclient after CVE-2016-7429 none

Description Trent D'Hooge 2017-02-16 15:39:05 UTC
Description of problem:

With the latest version of ntp from RHEL 6 and RHEL7 we found that multicastclient will no longer . For RHEL 7, version ntp-4.2.6p5-25.el7.x86_64 works properly, ntp-4.2.6p5-25.el7_3.1.x86_64 does not.


Version-Release number of selected component (if applicable):
ntp-4.2.6p5-25.el7_3.1.x86_64

How reproducible:

Install ntp-4.2.6p5-25.el7_3.1.x86_64. setup client to use

multicastclient 224.0.1.1

Steps to Reproduce:
ntpq -p
     remote           refid      st t when poll reach   delay   offset  jitter
==============================================================================
 eopal185        134.9.1.98       3 u  240   64   10    8.000  -422.55   0.000

note it is not locked into eopal185



Expected results:

vs a system still running the old version of ntp, ntp-4.2.6p5-25.el7.x86_64

ntpq -p
     remote           refid      st t when poll reach   delay   offset  jitter
==============================================================================
*equartz187      134.9.1.98       3 m    7   64  377    8.000   -0.119   0.536


Additional info:

removing patch 7429 from ntp allows ntp multicast to work again on RHEL7.

Comment 3 Ben Woodard 2017-02-16 16:29:36 UTC
According to one of LLNL's engineers this is related to: http://support.ntp.org/bin/view/Main/NtpBug3072

This is a regression caused by the update to NTP by:
https://access.redhat.com/errata/RHSA-2017:0252 and in particular:
https://bugzilla.redhat.com/show_bug.cgi?id=1397341

My working hypothesis is the author of the patch for the interface selection didn't understand how multicast works and didn't exempt the multicast addresses when it filtered out the mismatched IP/interface packets. Since multicast gives interfaces a new multicast address (which looks like a different IP address) the logic needs to accept those when NTP is participating on a multicast group.

Comment 6 Miroslav Lichvar 2017-02-16 16:59:08 UTC
Upstream bug:

https://bugs.ntp.org/show_bug.cgi?id=3356

Comment 11 Miroslav Lichvar 2017-02-17 13:49:47 UTC
Created attachment 1252015 [details]
Fix regression in multicastclient after CVE-2016-7429

Backported patch to fix multicast client to process both server and broadcast mode packets.

Comment 14 Travis Gummels 2017-02-17 14:38:31 UTC
Trent,

Test build is here:

http://people.redhat.com/tgummels/partners/.lc-d839231e87c805b7b71e764e0ed05825

Feedback appreciated.

Travis

Comment 15 Travis Gummels 2017-02-17 17:22:58 UTC
From: "Trent D'Hooge" <tdhooge>
To: "Travis Gummels" <tgummels>, "Jim Foraker" <foraker1>
Cc: "Ben Woodard" <woodard>
Sent: Friday, February 17, 2017 12:20:25 PM
Subject: Re: ntp bug for rhel7

looks good


[root@opal108:~]# ntpq -p
      remote           refid      st t when poll reach   delay offset  
jitter
==============================================================================
+namedhost       134.9.1.98       3 u   24   64  376    8.000 0.531   0.037
*eopal185        134.9.1.98       3 u   24   64  376    8.000 0.521   0.040
[root@opal108:~]# rpm -q ntp
ntp-4.2.6p5-26.test1422944.el7.x86_64