Bug 1423390
| Summary: | Review Request: prewikka | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Thomas Andrejak <thomas.andrejak> |
| Component: | Package Review | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | package-review, zbyszek |
| Target Milestone: | --- | Flags: | zbyszek:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-08-12 11:35:13 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Thomas Andrejak
2017-02-17 08:35:56 UTC
fedora-review complains:
[ ]: Package requires other packages for directories it uses.
Note: No known owner of /usr/lib/python2.7/site-
packages/prewikka/locale/de, /usr/lib/python2.7/site-
packages/prewikka/locale/pl/LC_MESSAGES, /usr/lib/python2.7/site-
packages/prewikka/locale/fr/LC_MESSAGES, /usr/lib/python2.7/site-
packages/prewikka/locale/it/LC_MESSAGES, /usr/lib/python2.7/site-
packages/prewikka/locale/pt_BR/LC_MESSAGES, /usr/lib/python2.7/site-
packages/prewikka/locale/de/LC_MESSAGES, /usr/lib/python2.7/site-
packages/prewikka/locale/fr, /usr/lib/python2.7/site-
packages/prewikka/locale/es/LC_MESSAGES, /usr/lib/python2.7/site-
packages/prewikka/locale/en, /usr/lib/python2.7/site-
packages/prewikka/locale, /usr/lib/python2.7/site-
packages/prewikka/locale/es, /usr/lib/python2.7/site-
packages/prewikka/locale/ru, /usr/lib/python2.7/site-
packages/prewikka/locale/pt_BR, /usr/lib/python2.7/site-
packages/prewikka/locale/ru/LC_MESSAGES, /usr/lib/python2.7/site-
packages/prewikka, /usr/lib/python2.7/site-
packages/prewikka/locale/it, /usr/lib/python2.7/site-
packages/prewikka/locale/en/LC_MESSAGES, /usr/lib/python2.7/site-
packages/prewikka/locale/pl
This should be covered by -f %{name}.lang, looks like this doesn't work for some reason.
I don't think you need to provide the versioned symlinks: they are only used when two versions of an application can be installed that behave *differently* for python2 and python3. Here, if python3 support is added in the future, there will be no difference in behaviour when running under python2 and python3, IIUC.
New files : SPEC : https://fedorapeople.org/~totol/prewikka.spec SRPM : https://fedorapeople.org/~totol/prewikka-3.1.0-1.fc26.src.rpm (In reply to Zbigniew Jędrzejewski-Szmek from comment #1) > fedora-review complains: > [ ]: Package requires other packages for directories it uses. > Note: No known owner of /usr/lib/python2.7/site- > packages/prewikka/locale/de, /usr/lib/python2.7/site- > packages/prewikka/locale/pl/LC_MESSAGES, /usr/lib/python2.7/site- > packages/prewikka/locale/fr/LC_MESSAGES, /usr/lib/python2.7/site- > packages/prewikka/locale/it/LC_MESSAGES, /usr/lib/python2.7/site- > packages/prewikka/locale/pt_BR/LC_MESSAGES, /usr/lib/python2.7/site- > packages/prewikka/locale/de/LC_MESSAGES, /usr/lib/python2.7/site- > packages/prewikka/locale/fr, /usr/lib/python2.7/site- > packages/prewikka/locale/es/LC_MESSAGES, /usr/lib/python2.7/site- > packages/prewikka/locale/en, /usr/lib/python2.7/site- > packages/prewikka/locale, /usr/lib/python2.7/site- > packages/prewikka/locale/es, /usr/lib/python2.7/site- > packages/prewikka/locale/ru, /usr/lib/python2.7/site- > packages/prewikka/locale/pt_BR, /usr/lib/python2.7/site- > packages/prewikka/locale/ru/LC_MESSAGES, /usr/lib/python2.7/site- > packages/prewikka, /usr/lib/python2.7/site- > packages/prewikka/locale/it, /usr/lib/python2.7/site- > packages/prewikka/locale/en/LC_MESSAGES, /usr/lib/python2.7/site- > packages/prewikka/locale/pl > This should be covered by -f %{name}.lang, looks like this doesn't work for > some reason. I try another approch, it add a new warning in rpmlint but the SPEC is more clean. What do you think ? > > I don't think you need to provide the versioned symlinks: they are only used > when two versions of an application can be installed that behave > *differently* for python2 and python3. Here, if python3 support is added in > the future, there will be no difference in behaviour when running under > python2 and python3, IIUC. Done Two small issues:
- COPYING is listed twice in %files
- the %description suggests that this is a GUI application. It'd be nice to reword it somehow to say that this is a backend for a browser interface.
+ package name is OK
+ license is acceptable (GPLv2+)
+ license is specified correctly
+ latest version
+ builds and installs correctly
+ Provides/Requires/BuildRequires appear correct
+ no scriptlets
> I try another approch, it add a new warning in rpmlint but the SPEC is more clean. What do you think ?
Nah, I think this is OK.
Package is APPROVED.
prewikka-3.1.0-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-73c319dbf2 prewikka-3.1.0-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-c77da35627 prewikka-3.1.0-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-298e644db4 prewikka-3.1.0-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-298e644db4 prewikka-3.1.0-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-c77da35627 prewikka-3.1.0-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-73c319dbf2 prewikka-3.1.0-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. prewikka-3.1.0-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. prewikka-3.1.0-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. |