Bug 1423430

Summary: Redeploy router certificates playbook couldn't work
Product: OpenShift Container Platform Reporter: Gaoyun Pei <gpei>
Component: InstallerAssignee: Scott Dodson <sdodson>
Status: CLOSED CURRENTRELEASE QA Contact: Gaoyun Pei <gpei>
Severity: medium Docs Contact:
Priority: medium    
Version: 3.5.0CC: aos-bugs, jokerman, mmccomas
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: No Doc Update
Doc Text:
undefined
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-03-08 14:08:31 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1397958    

Description Gaoyun Pei 2017-02-17 10:12:13 UTC
Description of problem:
When try to run redeploy-router-certificates.yml playbook, it got nonexistent role error.

[root@jenkins-slave-1 201702]# ansible-playbook -v -i host /usr/share/ansible/openshift-ansible/playbooks/byo/openshift-cluster/redeploy-router-certificates.yml 
Using /etc/ansible/ansible.cfg as config file
ERROR! the role 'Copy admin client config(s)' was not found in /usr/share/ansible/openshift-ansible/playbooks/byo/openshift-cluster/../../common/openshift-cluster/redeploy-certificates/roles:/etc/ansible/roles:/usr/share/ansible/openshift-ansible/playbooks/byo/openshift-cluster/../../common/openshift-cluster/redeploy-certificates

The error appears to have been in '/usr/share/ansible/openshift-ansible/playbooks/common/openshift-cluster/redeploy-certificates/router.yml': line 13, column 5, but may
be elsewhere in the file depending on the exact syntax problem.

The offending line appears to be:


  - name: Copy admin client config(s)
    ^ here



Version-Release number of selected component (if applicable):
openshift-ansible-playbooks-3.5.10-1.git.0.ba66b63.el7.noarch

How reproducible:
Always

Steps to Reproduce:
1.ansible-playbook -v -i host /usr/share/ansible/openshift-ansible/playbooks/byo/openshift-cluster/redeploy-router-certificates.yml


Actual results:


Expected results:


Additional info:

Comment 1 openshift-github-bot 2017-02-17 16:35:41 UTC
Commit pushed to master at https://github.com/openshift/openshift-ansible

https://github.com/openshift/openshift-ansible/commit/882f180a7f56d1b12c68620abf678216b81f2619
Fix indenting/ordering in router cert redeploy

Fixes Bug 1423430

Comment 3 Gaoyun Pei 2017-02-22 08:28:19 UTC
Test this bug with openshift-ansible-3.5.13-1.git.0.562e91d.el7.noarch, when running redeploy-router-certificates.yml playbook, it fails as:

TASK [Delete existing router certificate secret] *******************************
fatal: [x.compute-1.amazonaws.com]: FAILED! => {
    "changed": false, 
    "failed": true
}

MSG:

unsupported parameter for module: run_once

Comment 4 Scott Dodson 2017-03-06 20:43:13 UTC
https://github.com/openshift/openshift-ansible/pull/3575 merged

Comment 5 Gaoyun Pei 2017-03-07 09:24:49 UTC
Verify this bug with openshift-ansible-3.5.25-1.git.0.a40beae.el7.noarch.rpm

Redeploy-router-certificates.yml playbook is working as expected.

Run 'ansible-playbook -v -i host /usr/share/ansible/openshift-ansible/playbooks/byo/openshift-cluster/redeploy-router-certificates.yml' against an ocp-3.5 cluster, the router certs was updated and redeployed, app's route also works well.