Bug 1423830

Summary: kvirc: FTBFS in rawhide: invalid use of incomplete type 'DH {aka struct dh_st}'
Product: [Fedora] Fedora Reporter: Fedora Release Engineering <releng>
Component: kvircAssignee: nucleo <alekcejk>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 26CC: alekcejk, leigh123linux, ppisar, rdieter
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: kvirc-5.0.0-0.7.alpha2.fc26 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-07-23 03:55:04 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1383740, 1423041    
Attachments:
Description Flags
build.log
none
root.log
none
state.log
none
spec file to fix ftbfs none

Description Fedora Release Engineering 2017-02-17 14:55:05 UTC
Your package kvirc failed to build from source in current rawhide.

https://koji.fedoraproject.org/koji/taskinfo?taskID=17730478

For details on mass rebuild see https://fedoraproject.org/wiki/Fedora_26_Mass_Rebuild

Comment 1 Fedora Release Engineering 2017-02-17 14:55:11 UTC
Created attachment 1252838 [details]
build.log

Comment 2 Fedora Release Engineering 2017-02-17 14:55:14 UTC
Created attachment 1252839 [details]
root.log

Comment 3 Fedora Release Engineering 2017-02-17 14:55:16 UTC
Created attachment 1252840 [details]
state.log

Comment 4 Fedora End Of Life 2017-02-28 11:44:11 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 26 development cycle.
Changing version to '26'.

Comment 5 Petr Pisar 2017-03-01 13:07:12 UTC
This is an incompatibility with OpenSSL 1.1.0:

/builddir/build/BUILD/kvirc-5.0.0-alpha2/src/kvilib/net/KviSSL.cpp: In function 'DH* my_get_dh(int)':
/builddir/build/BUILD/kvirc-5.0.0-alpha2/src/kvilib/net/KviSSL.cpp:214:4: error: invalid use of incomplete type 'DH {aka struct dh_st}'
  dh->p=BN_bin2bn(p,sp,0);
    ^~
In file included from /usr/include/openssl/crypto.h:31:0,
                 from /usr/include/openssl/comp.h:16,
                 from /usr/include/openssl/ssl.h:47,
                 from /builddir/build/BUILD/kvirc-5.0.0-alpha2/src/kvilib/net/KviSSL.h:43,
                 from /builddir/build/BUILD/kvirc-5.0.0-alpha2/src/kvilib/net/KviSSL.cpp:27:
/usr/include/openssl/ossl_typ.h:104:16: note: forward declaration of 'DH {aka struct dh_st}'
 typedef struct dh_st DH;
                ^~~~~

Comment 6 leigh scott 2017-07-12 11:32:48 UTC
Created attachment 1296906 [details]
spec file to fix ftbfs

@nucleo Do you have any objection to me fixing the issue with the attached spec file patch?

Comment 7 Rex Dieter 2017-07-12 11:48:27 UTC
I think it safer and wiser to just use
BuildRequires: compat-openssl10-devel
for f26+ builds.  As menitioned in upstream issue,
https://github.com/kvirc/KVIrc/issues/2151

mixing openssl libs in the same process (Qt still uses compat-openssl10) is risky.

Comment 8 Fedora Update System 2017-07-12 12:52:11 UTC
kvirc-5.0.0-0.7.alpha2.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-b55e2dfd7b

Comment 9 Fedora Update System 2017-07-12 18:23:01 UTC
kvirc-5.0.0-0.7.alpha2.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-b55e2dfd7b

Comment 10 Fedora Update System 2017-07-23 03:55:04 UTC
kvirc-5.0.0-0.7.alpha2.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.