Bug 1424367

Summary: valgrind: FTBFS in rawhide
Product: [Fedora] Fedora Reporter: Fedora Release Engineering <releng>
Component: valgrindAssignee: Mark Wielaard <mjw>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: dodji, jakub, mjw, mjw, will_schmidt
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: valgrind-3.12.0-5.fc26 valgrind-3.12.0-9.fc25 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-07-13 19:19:42 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1423041    
Attachments:
Description Flags
build.log
none
root.log
none
state.log
none
patch to remove R2 from clobber list none

Description Fedora Release Engineering 2017-02-17 16:52:42 UTC 
Your package valgrind failed to build from source in current rawhide.

https://koji.fedoraproject.org/koji/taskinfo?taskID=17790661

For details on mass rebuild see https://fedoraproject.org/wiki/Fedora_26_Mass_Rebuild
Comment 1 Fedora Release Engineering 2017-02-17 16:52:49 UTC 
Created attachment 1254378 [details]
build.log
Comment 2 Fedora Release Engineering 2017-02-17 16:52:54 UTC 
Created attachment 1254379 [details]
root.log
Comment 3 Fedora Release Engineering 2017-02-17 16:52:57 UTC 
Created attachment 1254380 [details]
state.log
Comment 4 Mark Wielaard 2017-02-17 17:18:20 UTC 
This seems to be ppc64/ppc64le upstream bug. As pointed out by https://gcc.gnu.org/gcc-7/changes.html
PowerPC / PowerPC64 / RS6000
GCC now diagnoses inline assembly that clobbers register r2. This has always been invalid code, and is no longer quietly tolerated.

Upstream working on a fix.
Comment 5 Will Schmidt 2017-02-17 17:30:11 UTC 
Created attachment 1254892 [details]
patch to remove R2 from clobber list

I just posted this (attached) patch to the valgrind-developers list.  Fixes build issue locally, when building valgrind against upstream/new gcc. 

   On ppc64*, R2 is the TOC pointer, should not be considered a
    scratch register, and thus should not be in the clobber list.
    This is called out in newer GCC releases and triggers a
    compile time error.

    Thusly, remove R2 from the clobber list.
Comment 6 Mark Wielaard 2017-02-17 21:50:14 UTC 
That patch fixes things. All arches build now.

There is an issue with various tests though because prlimit64 isn't hooked on ppc64[le] (syscall 325) and arm64 (syscall 261). But I'll file another bug for that.
Comment 7 Fedora Update System 2017-07-05 14:02:05 UTC 
valgrind-3.12.0-9.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-ffd8b851cc
Comment 8 Fedora Update System 2017-07-06 03:53:36 UTC 
valgrind-3.12.0-9.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-ffd8b851cc
Comment 9 Fedora Update System 2017-07-13 19:19:42 UTC 
valgrind-3.12.0-9.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.