Bug 142453
Summary: | RFE: add reload and force-reload init script actions | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Ville Skyttä <scop> | ||||||
Component: | pcmcia-cs | Assignee: | Pete Zaitcev <zaitcev> | ||||||
Status: | CLOSED CANTFIX | QA Contact: | |||||||
Severity: | medium | Docs Contact: | |||||||
Priority: | medium | ||||||||
Version: | rawhide | CC: | k.georgiou, notting, tburke | ||||||
Target Milestone: | --- | Keywords: | FutureFeature, Patch | ||||||
Target Release: | --- | ||||||||
Hardware: | All | ||||||||
OS: | Linux | ||||||||
Whiteboard: | |||||||||
Fixed In Version: | Doc Type: | Enhancement | |||||||
Doc Text: | Story Points: | --- | |||||||
Clone Of: | Environment: | ||||||||
Last Closed: | 2007-01-03 14:49:50 UTC | Type: | --- | ||||||
Regression: | --- | Mount Type: | --- | ||||||
Documentation: | --- | CRM: | |||||||
Verified Versions: | Category: | --- | |||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||
Embargoed: | |||||||||
Bug Depends On: | 142451 | ||||||||
Bug Blocks: | 145007 | ||||||||
Attachments: |
|
Description
Ville Skyttä
2004-12-09 20:16:39 UTC
Created attachment 108254 [details]
reload and force-reload actions for pcmcia init script
Oh, and in order to make the exit codes in this patch (and otherwise in /etc/init.d/pcmcia) work, see bug 142451. Dave, I noticed you did some cleanup in the pcmcia-cs init script in Rawhide, how about including this patch and the fix from bug 142451 while at it too? We claim LSB 1.3 here: http://www.redhat.com/software/rhel/configuration/ LSB 1.3 (and 2.1.0) clause 14.2 says that reload is optional. It also says: - force-reload is not optional (we not have it, so we're not compliant) - exit code 7 is reserved for the future I don't think we should take the requested patch for RHEL 4 as is, but it's obvious that something has to be done for LSB 2.x compliance. OTOH, it looks that LSB is a rather broken standard, because nobody in their right mind provides force-reload. Perhaps we ought to take an RFE for plain reload. http://refspecs.freestandards.org/LSB_2.1.0/LSB-generic/LSB-generic/iniscrptact.html http://refspecs.freestandards.org/LSB_2.0.1/LSB-generic/LSB-generic/iniscrptact.html http://refspecs.freestandards.org/LSB_1.3.0/gLSB/gLSB/iniscrptact.html LSB compliance involves supporting such functions for potential third-party scripts; it does not apply to the system scripts as shipped. Note that the "meat" in this RFE is support for the reload/force-reload actions in the first place, not LSB per se. I just thought making them LSB compliant would be a good idea. Adjusting summary accordingly. Can we add this to FC4 at least? Warren, yes, I think it's a good patch. However, I do not like the use of pidof. I guess that it's used in "status" command to return "real" information in case cardmgr was killed with -9. This consideration is not applicable in case of the "reload" command. My disagreement about exit code 7 was ill-founded. I read the spec inattentively. Created attachment 112696 [details]
Candidate #2 - use pid file
No objections here. On the other hand, with recent changes in 2.6.11+ kernels, I gather cardmgr will be obsolete soon anyway. This package isn't built for RHEL-4. In addition, there's already a pcmcia-cs errata for U1 which is in NEEDRHNQA, so I don't see the benefit to cracking it open to get this fix in. I see this has been committed to CVS/devel, but there's no new package available in Rawhide yet. Could it be built? pcmcia-cs is obsolete and has been removed from Fedora Core. It is not present in FC5 or FC6, the only fully supported versions of Fedora Core. (FC3 and FC4 are supported by Fedora Legacy for security fixes only.) It has been replaced by pcmciautils. Due to the change in codebase, can you please retest this bug against pcmciautils in FC5 or FC6? If the bug is still present there, please change the Component to pcmciautils and the version appropriately. Thanks! If there is no response within several weeks, the bug will be closed. Per the previous comment, closing bug since pcmcia-cs is no longer supported. If a similar bug still exists in pcmciautils, the replacement for pcmcia-cs, please reopen the bug or file a new one. |