Bug 1424641

this is mostly a dupe of bug 1420708.

this is also related to bug 1386872, where in rhel-7.4 you will be able to set the MAC address for virtual devices, like team.

I would disagree that this is a dup of bug 1420708. 1420708 states that the MAC address should be based on the alphabetic order of the slave names. This would eliminate the randomness of the MAC addresses, assuming any fix is applied to teams as well as bonds BUT would not eliminate the issue of being about to assign a fixed address. It seems more related to 1386872. But a comment in that bug specifically states "For teams, teamd takes care of setting a MAC address for the device and so the desired value should be set in the JSON team configuration." Which does imply that the bug isn't needed BUT I cannot find anything that tells me what the jason config would look like.

Adding a hwaddr entry to the team config can be used to set the team MAC address.

# cat ifcfg-team0 | grep TEAM_CONFIG
TEAM_CONFIG="{ 	\"device\":		\"team0\", 	\"hwaddr\": \"02:02:02:02:02:02\",    \"runner\": { 		\"name\": \"lacp\", 		\"active\": true, 		\"fast_rate\": true, 		\"tx_hash\": [\"eth\", \"ipv4\", \"ipv6\"] }, 	\"link_watch\":		{\"name\": \"ethtool\"}, 	\"ports\":		{\"enp9s0f0\": {}, \"enp9s0f1\": {}, \"eno1\": {}} }"

Note after making the change you need to tell Network manager to reload the configuration

nmcli conn reload team0

# for x in 1 2 3 4 5; do nmcli conn down team0; sleep 5 ; nmcli conn up team0; ip l l team0; done | grep link/ether
    link/ether 02:02:02:02:02:02 brd ff:ff:ff:ff:ff:ff
    link/ether 02:02:02:02:02:02 brd ff:ff:ff:ff:ff:ff
    link/ether 02:02:02:02:02:02 brd ff:ff:ff:ff:ff:ff
    link/ether 02:02:02:02:02:02 brd ff:ff:ff:ff:ff:ff
    link/ether 02:02:02:02:02:02 brd ff:ff:ff:ff:ff:ff

I am changing the status to closed not a bug since there is a configuration setting that eliminates the problem.

Maybe NM still should handle this better.
At least, there has a ethernet.cloned-mac-address settings, which apparently doesn't work.

Beniamino, what do you think?

(In reply to Thomas Haller from comment #5)
> Maybe NM still should handle this better.
> At least, there has a ethernet.cloned-mac-address settings, which apparently
> doesn't work.
> 
> Beniamino, what do you think?

It's not that easy as with other devices, because teamd tries to
change the MAC address of the team device at various points, for
example each time a port is added or according to the
runner.hwaddr_policy configuration. So, just setting the MAC of the
team from NM before starting teamd won't work.

A cleaner alternative would be to inject the "hwaddr" property in the
JSON configuration (and throw a warning/error if it is already present
with a different value), so that teamd will manage the MAC by itself:
when "hwaddr" is explicitly set, teamd locks it to the given value
[1]. But this solution depends on the availability of Jansson compiled
in, as we need it to parse and modify the configuration. When Jansson
is not available, maybe we can just ignore the cloned-mac property and
print a warning.

Thomas, what's your opinion?

[1] https://github.com/jpirko/libteam/blob/master/teamd/teamd.c#L868

(In reply to Beniamino Galvani from comment #6)
> (In reply to Thomas Haller from comment #5)
> > Maybe NM still should handle this better.
> > At least, there has a ethernet.cloned-mac-address settings, which apparently
> > doesn't work.
> > 
> > Beniamino, what do you think?
> 
> It's not that easy as with other devices, because teamd tries to
> change the MAC address of the team device at various points, for
> example each time a port is added or according to the
> runner.hwaddr_policy configuration. So, just setting the MAC of the
> team from NM before starting teamd won't work.
> 
> A cleaner alternative would be to inject the "hwaddr" property in the
> JSON configuration (and throw a warning/error if it is already present
> with a different value), so that teamd will manage the MAC by itself:
> when "hwaddr" is explicitly set, teamd locks it to the given value
> [1]. But this solution depends on the availability of Jansson compiled
> in, as we need it to parse and modify the configuration. When Jansson
> is not available, maybe we can just ignore the cloned-mac property and
> print a warning.
> 
> Thomas, what's your opinion?

Injecting the hwaddr into the json sounds like a good solution.

We could make libjansson a strict requirement of the team plugin, that seems reasonable, as also teamd has that requirement already.

On the other hand, it should still be possible to build libnm without linking against libjansson.

Please review bg/team-cloned-mac-rh1424641.

(In reply to Beniamino Galvani from comment #8)
> Please review bg/team-cloned-mac-rh1424641.

very nice. Pushed some fixups.

lgtm

Squashed the fixups and merged to master as:

https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=36bb22f598b6b25503041bcbc283aa21510f3754

Thanks!

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2017:2299