Bug 1424764

Summary:	Coverty scan return false positive regarding crypto
Product:	[Community] GlusterFS	Reporter:	Michael S. <misc>
Component:	core	Assignee:	M. Scherer <mscherer>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.11.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-05-30 18:44:10 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Michael S. 2017-02-19 10:14:27 UTC

Description of problem:
Coverty scan return false positive regarding crypto, since there is code using random.

However taht's either dht code, or code that generate errors, and none is crypto related (nor critical). So random is fine, and in order to make coverty scan report useful,  would like to filter them. 

I am not 100% sure of the syntax, but that's the one documented around. If someone can confirm the syntax, please do not hesitate :)


Version-Release number of selected component (if applicable):
git head

How reproducible:
each time

Steps to Reproduce:
1. read coverty scan report



Actual results:
false positives

Expected results:
less false positives

Additional info:

Comment 1 Worker Ant 2017-02-19 10:14:46 UTC

REVIEW: https://review.gluster.org/16668 (Filter coverty false positives) posted (#1) for review on master by Michael Scherer (misc)

Comment 2 Worker Ant 2017-02-24 14:52:49 UTC

COMMIT: https://review.gluster.org/16668 committed in master by Shyamsundar Ranganathan (srangana) 
------
commit ff2ba49d02dc99b0c3de5712348ae9d588be7ad7
Author: Michael Scherer <misc>
Date:   Sun Feb 19 11:06:56 2017 +0100

    Filter coverty false positives
    
    Since random is not used for anything cryptographically related,
    it is fine to use it in those instances.
    
    Change-Id: I720172285f60d6bc477c7169c7286fc018ebdf8f
    BUG: 1424764
    Signed-off-by: Michael Scherer <misc>
    Reviewed-on: https://review.gluster.org/16668
    Smoke: Gluster Build System <jenkins.org>
    Tested-by: Nigel Babu <nigelb>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Shyamsundar Ranganathan <srangana>

Comment 3 Shyamsundar 2017-05-30 18:44:10 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.11.0, please open a new bug report.

glusterfs-3.11.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-May/000073.html
[2] https://www.gluster.org/pipermail/gluster-users/