Bug 1424796

Summary:	Remove deadcode found by coverty in glusterd-utils.c
Product:	[Community] GlusterFS	Reporter:	Michael S. <misc>
Component:	core	Assignee:	Michael S. <misc>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.11.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-05-30 18:44:34 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Michael S. 2017-02-19 14:40:38 UTC

Description of problem:

There is lots of deadcode around found by coverty. The patch sent to gerrit is one example

See https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2017-02-17-8e7a8ea8/html/1/132glusterd-utils.c.html#error

Version-Release number of selected component (if applicable):

git master

How reproducible:

each time

Steps to Reproduce:
1. Look at the report
2. Look at the code in git
3.

Actual results:
There is deadcode

Expected results:
There is no deadcode

Additional info:
While the code is harmless, anything that can help clean coverty is a good idea.

Comment 1 Worker Ant 2017-02-19 14:40:58 UTC

REVIEW: https://review.gluster.org/16672 (Remove deadcode, found by covertyscan) posted (#1) for review on master by Michael Scherer (misc)

Comment 2 Worker Ant 2017-02-19 19:43:15 UTC

COMMIT: https://review.gluster.org/16672 committed in master by Atin Mukherjee (amukherj) 
------
commit bcea9e274fc13c56431e1b0553661b4048c206ca
Author: Michael Scherer <misc>
Date:   Sun Feb 19 15:36:27 2017 +0100

    Remove deadcode, found by covertyscan
    
    Since ctx_dict is either assigned to the value of aggr,
    or we goto to out, there is no need for a 2nd goto.
    
    Change-Id: I6c4295c61e6ff412ed7b85421dcae13df8088d7c
    BUG: 1424796
    Signed-off-by: Michael Scherer <misc>
    Reviewed-on: https://review.gluster.org/16672
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: Atin Mukherjee <amukherj>
    Tested-by: Atin Mukherjee <amukherj>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Shyamsundar Ranganathan <srangana>
    CentOS-regression: Gluster Build System <jenkins.org>

Comment 3 Shyamsundar 2017-05-30 18:44:34 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.11.0, please open a new bug report.

glusterfs-3.11.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-May/000073.html
[2] https://www.gluster.org/pipermail/gluster-users/