Bug 1424802

Summary:	Missing call to va_end in xlators/cluster/dht/src/dht-common.c
Product:	[Community] GlusterFS	Reporter:	Michael S. <misc>
Component:	distribute	Assignee:	bugs <bugs>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.11.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-05-30 18:44:34 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Michael S. 2017-02-19 15:18:39 UTC

Description of problem:
Missing call to va_end in xlators/cluster/dht/src/dht-common.c.
Found by coverty

Version-Release number of selected component (if applicable):
git head

How reproducible:
each time

Steps to Reproduce:
1. Look at https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2017-02-17-8e7a8ea8/html/1/905dht-common.c.html#error:16
2. See missing va_end
3.

Actual results:
No va_end

Expected results:
Having va_end

Additional info:

Comment 1 Worker Ant 2017-02-19 15:18:56 UTC

REVIEW: https://review.gluster.org/16673 (Ressources used by va_start must be freed with va_end) posted (#1) for review on master by Michael Scherer (misc)

Comment 2 Worker Ant 2017-02-20 23:32:42 UTC

COMMIT: https://review.gluster.org/16673 committed in master by Shyamsundar Ranganathan (srangana) 
------
commit 4a1740d3e8fbccc18772c0fc5f70f2cd7443d51e
Author: Michael Scherer <misc>
Date:   Sun Feb 19 16:16:00 2017 +0100

    Ressources used by va_start must be freed with va_end
    
    Coverty warn of the defect.
    
    Change-Id: Ie86684520e1d5b41237ab8d3247c24564a1a8639
    BUG: 1424802
    Signed-off-by: Michael Scherer <misc>
    Reviewed-on: https://review.gluster.org/16673
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: Shyamsundar Ranganathan <srangana>
    Tested-by: Raghavendra G <rgowdapp>
    Reviewed-by: Susant Palai <spalai>
    Reviewed-by: Raghavendra G <rgowdapp>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>

Comment 3 Shyamsundar 2017-05-30 18:44:34 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.11.0, please open a new bug report.

glusterfs-3.11.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-May/000073.html
[2] https://www.gluster.org/pipermail/gluster-users/