Bug 1424815

Summary:	Fix erronous comparaison of flags resulting in UUID always sent
Product:	[Community] GlusterFS	Reporter:	Michael S. <misc>
Component:	core	Assignee:	bugs <bugs>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	amukherj, bugs
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.11.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-05-30 18:44:34 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Michael S. 2017-02-19 16:01:34 UTC

Description of problem:
Covertyscan show a warning regarding xlators/mgmt/glusterd/src/glusterd-handshake.c, where the code is always sending uuid, because a test using '|' with a constant, rather than '&'.



Version-Release number of selected component (if applicable):
git head

How reproducible:
each time

Steps to Reproduce:
1.look at https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2017-02-17-8e7a8ea8/html/1/98glusterd-handshake.c.html#error
2.
3.

Actual results:
there is a '|' that do not make sense.

Expected results:
it should likely be a '&', or the code should be removed. (the if)

Additional info:

Comment 1 Worker Ant 2017-02-19 16:03:03 UTC

REVIEW: https://review.gluster.org/16675 (Fix erronous comparaison of flags) posted (#1) for review on master by Michael Scherer (misc)

Comment 2 Worker Ant 2017-02-21 03:37:57 UTC

COMMIT: https://review.gluster.org/16675 committed in master by Atin Mukherjee (amukherj) 
------
commit 420c2d03543a35f1f5483f200541577f4a606b22
Author: Michael Scherer <misc>
Date:   Sun Feb 19 16:54:39 2017 +0100

    Fix erronous comparaison of flags
    
    Using a binary 'or' mean that we always send the
    UUID, even when not required.
    
    Found by coverty scan
    
    Change-Id: Ifc4bff6b2f64febd5d2f038538218c2183518fd5
    BUG: 1424815
    Signed-off-by: Michael Scherer <misc>
    Reviewed-on: https://review.gluster.org/16675
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: Prashanth Pai <ppai>
    Tested-by: Shyamsundar Ranganathan <srangana>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>

Comment 3 Shyamsundar 2017-05-30 18:44:34 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.11.0, please open a new bug report.

glusterfs-3.11.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-May/000073.html
[2] https://www.gluster.org/pipermail/gluster-users/