Bug 1424886

Summary: Password written in clear text in heat-api.log with DEBUG mode [openstack-10]
Product: Red Hat OpenStack Reporter: Summer Long <slong>
Component: openstack-heatAssignee: Zane Bitter <zbitter>
Status: CLOSED ERRATA QA Contact: Amit Ugol <augol>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 10.0 (Newton)CC: augol, gmollett, jschluet, mburns, rhel-osp-director-maint, sbaker, shardy, srevivo, zbitter
Target Milestone: asyncKeywords: Security, ZStream
Target Release: 10.0 (Newton)   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: openstack-heat-7.0.2-4.el7ost Doc Type: Release Note
Doc Text:
Story Points: ---
Clone Of: 1424879 Environment:
Last Closed: 2017-05-17 12:21:31 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Summer Long 2017-02-20 02:40:29 UTC 
+++ This bug was initially created as a clone of Bug #1424879 +++

Description of problem:
Reported by Hans Feldt, Ericsson

Password written in clear text in heat-api.log with DEBUG mode
Because this is debug, it is a hardening issue; no CVE is attached.

Upstream bug: https://bugs.launchpad.net/heat/+bug/1664792

Affected code:
heat/common/serializers.py:
 31 class JSONResponseSerializer(object):
 32
 33 def to_json(self, data):
 34 def sanitizer(obj):
 35 if isinstance(obj, datetime.datetime):
 36 return obj.isoformat()
 37 return six.text_type(obj)
 38
 39 response = jsonutils.dumps(data, default=sanitizer)
 40 LOG.debug("JSON response : %s" % response) # <- HERE

Version-Release number of selected component (if applicable):
openstack-heat-7.0.0-7.el7ost

Steps to Reproduce:
1. Create overcloud
2. View /var/log/heat/heat-api.log
3. Grep for AdminPassword

Actual results:
Plain text is used for passwords

Expected results:
Plain text should never be used for passwords
Comment 2 Amit Ugol 2017-04-05 09:52:02 UTC 
Now shows ****.
Comment 5 errata-xmlrpc 2017-05-17 12:21:31 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2017:1243