Bug 1425220
| Summary: | rubygem-rspec-support: RPM directory is different from directory used in prep/check | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jun Aruga <jaruga> |
| Component: | rubygem-rspec-support | Assignee: | Mamoru TASAKA <mtasaka> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 26 | CC: | jaruga, mtasaka |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-05-04 14:49:34 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1419061 | ||
> - rubygem-byebug
> - rubygem-rspec-core
> - rubygem-rspec-expectations
> - rubygem-rspec-mocks
Hi Mamoru,
I am considering to create BZ tickets for these packages too, after I am going to talk with you about the solution.
1 BZ ticket for 1 package looks good.
I can help you to fix it in cooperation, if you like.
(In reply to Jun Aruga from comment #0) > Description of problem: > > I found below patch was applied in prep section. > rubygem-rspec-support-3.6.0.beta2-fix-for-ruby-2.4.0.patch Note that the above change is made by _you_. (Patch0 is okay, this is meant to modify only test suite file) > https://bugzilla.redhat.com/show_bug.cgi?id=1419061#c1
Ah sorry I made mistake for fixing it.
I should not put %patch1 next line of %patch0.
(
cd %{gem_name}-%{version}
%patch0 -p1
+%patch1 -p1
)
> - rubygem-rspec-support > - rubygem-byebug > - rubygem-rspec-core > - rubygem-rspec-expectations Thank you for your quick fixing, I checked above 4 packages have already been fixed. > - rubygem-rspec-mocks This bug appears to have been reported against 'rawhide' during the Fedora 26 development cycle. Changing version to '26'. This message is a reminder that Fedora 26 is nearing its end of life. Approximately 4 (four) weeks from now Fedora will stop maintaining and issuing updates for Fedora 26. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '26'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 26 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. > - rubygem-rspec-mocks
It looks fixed on rawhide and f26.
|
Description of problem: I found below patch was applied in prep section. rubygem-rspec-support-3.6.0.beta2-fix-for-ruby-2.4.0.patch This patch modifies lib/rspec/support/object_formatter.rb. However the file in rubygem-rspec-support-3.5.0-2.fc26.noarch.rpm is not modified for the patch. Why? Because seeing build.log carefully. %prep section => Apply patch for directory [A] %build section => %gem_install => install files from [B] to [C] => patch in %prep section is not applied! %check section => Test for directory [A] => the tests are passed by chance. [A] /builddir/build/BUILD/rspec-support-3.5.0/rspec-support-3.5.0 [B] /builddir/build/BUILD/rspec-support-3.5.0/ [C] /builddir/build/BUILD/rspec-support-3.5.0/usr/share/gems/gems/rspec-support-3.5.0 Possible Solutions: Below package's cases using *-tests.tar.gz file looks better instead of using rubygem-%{gem_name}-%{version}-full.tar.gz to prevent this kind of mistake? - rubygem-flexmock http://pkgs.fedoraproject.org/cgit/rpms/rubygem-flexmock.git/tree/rubygem-flexmock.spec %{gem_name}-v%{version}-test-missing-files.tar.gz - rubygem-activesupport http://pkgs.fedoraproject.org/cgit/rpms/rubygem-activesupport.git/tree/rubygem-activesupport.spec %{gem_name}-%{version}-tests.tgz Version-Release number of selected component (if applicable): rubygem-rspec-support-3.5.0-2.fc26 How reproducible: Steps to Reproduce: 1. mock -r fedora-rawhide-x86_64 rubygem-rspec-support-3.5.0-2.fc26.src.rpm To see files in RPM file. 2. rpm2cpio rubygem-rspec-support-3.5.0-2.fc26.noarch.rpm | cpio -idmv Actual results: Patches in %prep section are not applied. Expected results: Patches in %prep section are applied. Additional info: Not only rubygem-rspec-support, at least below packages might also have a same issue. $ grep -r full.tar.gz */*.spec - rubygem-byebug - rubygem-rspec-core - rubygem-rspec-expectations - rubygem-rspec-mocks