Bug 1425728

Summary:	Page will direct to wrong url when Config file successfully created from new created secret
Product:	OpenShift Container Platform	Reporter:	XiaochuanWang <xiaocwan>
Component:	Management Console	Assignee:	Samuel Padgett <spadgett>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Yadan Pei <yapei>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	3.5.0	CC:	aos-bugs, jforrest, jokerman, mmccomas, tdawson, yanpzhan
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-03-08 13:22:03 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description XiaochuanWang 2017-02-22 09:04:23 UTC

Description of problem:
Page will go to "Create Secret" page when create Config file successfully from new created secret.
Page will browse repeatedly between "Add Config Files" page and "Create Secret" page by Cancel button when Config file successfully created from new created secret.

Version-Release number of selected component (if applicable):
v3.5.0.32-1+4f84c83

How reproducible:
Always

Steps to Reproduce:
1. oc run myrun --image=aosqe/hello-openshift
2. Go to browse/dc/myrun?tab=configuration -> click "Add Config Files" -> Click Create Secret
3. Fill "*Secret Name" and "*Password or Token"，Click Create
4. Choose the created secret from Source drop-down list, fill a random Mount Path like"/data", Hit "Add"
5. Hit Cancel on "Create Secret" page, page direct to "Add Config Files" which is correct
6. Hit Cancel on "Add Config Files" page but the url is directly to "Create Secret" page (bug in "Actual results" 6)
7. Repeat step5-6

Actual results:
4. Page direct to "Create Secret" page as below
create-secret?then=%2Fproject%2Fxiaocwan-c2%2Fadd-config-volume%3Fkind%3DDeploymentConfig%26name%3Dmyrun
6. Page direct to "Create Secret" page again
7. Page will browse between "Add Config Files" and "Add Config Files" and never return back

Expected results:
4. Page should return back when create Config file successfully from created secret.
6,7. Page will return back when cancel from "Add Config Files" page 

Additional info:

Comment 1 openshift-github-bot 2017-02-22 15:13:32 UTC

Commit pushed to master at https://github.com/openshift/origin-web-console

https://github.com/openshift/origin-web-console/commit/bbad484ce5750f6440a437414844911f098d9fa5
Bug 1425728 - Fix cancel from add config files page

If you click create secret, then cancel out both forms, you go back to
the create secret page. Use `$window.history.back()` instead of a `then`
parameter from the create secret page to prevent this.

https://bugzilla.redhat.com/show_bug.cgi?id=1425728

Comment 2 Troy Dawson 2017-02-24 20:43:45 UTC

This has been merged into ocp and is in OCP v3.5.0.34 or newer.

Comment 4 Yanping Zhang 2017-02-27 02:55:50 UTC

Checked on openshift v3.5.0.34
Steps to test:
1. Create dc in project
2. On dc page, click "Add Config Files" -> Click Create Secret, after Fill "*Secret Name" and "*Password or Token"，Click Create, it will return to adding config files page, choose the created secret, fill a mount path, then click "Add", it succeeds and returns to dc page.
3.On dc page, click "Add Config Files" -> Click Create Secret, on creating secret page, click "Cancel", it returns to adding config files page, and click "Cancel" on the page, it returns to dc page.

The bug has been fixed, so move it to Verified.

Comment 6 Troy Dawson 2017-04-07 14:17:14 UTC

This bug was never seen by customers, only internally.  Removing from errata.