Bug 1425899

Summary: rpmdiff found issue with acpica-tools.spec's changelog
Product: Red Hat Enterprise Linux 7 Reporter: Dean Nelson <dnelson>
Component: acpica-toolsAssignee: Al Stone <ahs3>
Status: CLOSED ERRATA QA Contact: Mike Gahagan <mgahagan>
Severity: low Docs Contact:
Priority: low    
Version: 7.3CC: ahs3, bhu
Target Milestone: rc   
Target Release: 7.6   
Hardware: Unspecified   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: No Doc Update
Doc Text:
undefined
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-10-30 11:46:13 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1532680    

Description Dean Nelson 2017-02-22 17:19:53 UTC
Description of problem:

rpmdiff found issue with "RPM changelog", saying the following from acpica-tools.spec needs inspection...

   * Wed Jul 15 2015 Dean Nelson <dnelson> - 20150619-3
  -- Remove acpitests-unix-20150619 directory from the build because it was a
  +- Remove acpitests-unix-20160527 directory from the build because it was a
     mistake that it was present and it complicated the fixing of the file

This results from the use of the "%{version}" macro that appears in the changelog. The percent character has a special meaning, so it has to be escaped by another '%' to avoid the substitution, like so...

diff --git a/acpica-tools.spec b/acpica-tools.spec
index a9c69eb..63e1d51 100644
--- a/acpica-tools.spec
+++ b/acpica-tools.spec
@@ -182,7 +182,7 @@ fi
 - Refresh existing patches and add/delete ones to enable a clean build.
 
 * Wed Jul 15 2015 Dean Nelson <dnelson> - 20150619-3
-- Remove acpitests-unix-%{version} directory from the build because it was a
+- Remove acpitests-unix-%%{version} directory from the build because it was a
   mistake that it was present and it complicated the fixing of the file
   permissions done related to RHBZ 1211328's requested rebase.


The importance of this fix is so low, that it will have to wait until something worth fighting through the errata process (with its rpmdiff and covscan morass) arrives.  ;-)

Comment 4 Al Stone 2018-01-26 22:33:13 UTC
Fedora package has a patch applied for this problem; just need to pull it in for 7.6.

Comment 5 Beth Uptagrafft 2018-07-11 19:07:54 UTC
(In reply to Al Stone from comment #4)
> Fedora package has a patch applied for this problem; just need to pull it in
> for 7.6.

Al, are we going to do this in 7.6?

Comment 6 Al Stone 2018-07-13 00:37:43 UTC
Patch applied, build done:

https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=17141838

Comment 8 Mike Gahagan 2018-07-26 15:54:06 UTC
Issue was fixed in 20160527-2 per rpmdiff output.

Comment 10 errata-xmlrpc 2018-10-30 11:46:13 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:3305