Bug 1426477
Summary: | libvirtd crashes when calling virConnectGetAllDomainStats on a VM which has empty cdrom drive | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Han Han <hhan> |
Component: | libvirt | Assignee: | Libvirt Maintainers <libvirt-maint> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | high | Docs Contact: | |
Priority: | unspecified | ||
Version: | 26 | CC: | agedosier, ahadas, berrange, bugs, chhu, clalancette, crobinso, dyuan, hhan, itamar, laine, libvirt-maint, michal.skrivanek, mzhan, pkrempa, pzhang, rbalakri, veillard, virt-maint, xuzhang, yanqzhan |
Target Milestone: | --- | Keywords: | Regression, Reopened, TestBlocker |
Target Release: | --- | ||
Hardware: | x86_64 | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | 1420718 | Environment: | |
Last Closed: | 2017-05-04 17:49:38 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | Virt | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 1420718 | ||
Bug Blocks: |
Description
Han Han
2017-02-24 02:14:00 UTC
Version: libvirt-3.1.0-1.fc26.x86_64 Reproduced via virsh: ➜ ~ virsh attach-disk V /tmp/boot.iso sda --config --type cdrom Disk attached successfully ➜ ~ virsh change-media V sda --eject --config Successfully ejected media. ➜ ~ virsh start V Domain V started ➜ ~ virsh domstats V error: Disconnected from qemu:///system due to I/O error error: End of file while reading data: Input/output error Fedora bugs with all private comments are useless. Please file one with proper data and trim the private information. Upstream fixed this as: commit c3de387380f6057ee0e46cd9f2f0a092e8070875 Author: Peter Krempa <pkrempa> Date: Thu Feb 23 10:07:30 2017 +0100 qemu: Don't update physical storage size of empty drives Previously the code called virStorageSourceUpdateBlockPhysicalSize which did not do anything on empty drives since it worked only on block devices. After the refactor in c5f6151390 it's called for all devices and thus attempts to deref the NULL path of empty drives. Add a check that skips the update of the physical size if the storage source is empty. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1420718 This bug appears to have been reported against 'rawhide' during the Fedora 26 development cycle. Changing version to '26'. This has been in f26+ since libvirt 3.1.0 |