Bug 1426639

New commit detected on ManageIQ/manageiq/euwe:
https://github.com/ManageIQ/manageiq/commit/10d36ceba831e5f2a0a6350a29922694a6e53f35

commit 10d36ceba831e5f2a0a6350a29922694a6e53f35
Author:     Greg Blomquist <blomquisg>
AuthorDate: Mon Jan 23 15:49:14 2017 -0500
Commit:     Satoe Imaishi <simaishi>
CommitDate: Thu Mar 2 14:07:20 2017 -0500

    Merge pull request #13368 from mtho11/jdbc_drivers_for_feed
    
    Retrieve middleware JDBC Drivers for a feed.
    (cherry picked from commit c0cef1da6a4fe5f84ec7e780d333810e5105b13e)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1426639

 app/models/manageiq/providers/hawkular/middleware_manager.rb | 8 ++++++++
 1 file changed, 8 insertions(+)

New commit detected on ManageIQ/manageiq/euwe:
https://github.com/ManageIQ/manageiq/commit/39a37d0f350828103ada4d169cd4f592a2a3698d

commit 39a37d0f350828103ada4d169cd4f592a2a3698d
Author:     Martin Hradil <himdel>
AuthorDate: Tue Jan 24 09:36:17 2017 +0000
Commit:     Satoe Imaishi <simaishi>
CommitDate: Thu Mar 2 14:56:56 2017 -0500

    Merge pull request #82 from mtho11/miq_pr_12381
    
    For Middleware, provide select JDBC driver tab to more easily input Drivers loaded in servers
    (cherry picked from commit 39377c2f88d33428401e8da6a2dd1c441d27e592)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1426639

 .../middleware_datasource_controller.js            | 155 +++++++++++++--------
 .../middleware_datasource_service.js               |  93 +++++++++++--
 app/controllers/middleware_server_controller.rb    |  12 ++
 .../middleware_server/_add_datasource.html.haml    |   2 +-
 .../_add_datasource_step1.html.haml                |  12 +-
 .../_add_datasource_step2.html.haml                |  78 +++--------
 .../_add_datasource_step3.html.haml                |  21 ++-
 .../middleware_server/_choose_datasource.html.haml |  16 +--
 .../middleware_server/_existing_driver.html.haml   |  10 ++
 .../middleware_server/_specify_driver.html.haml    |  49 +++++++
 config/routes.rb                                   |   1 +
 .../middleware_add_datasource_controller_spec.js   |  21 +--
 12 files changed, 306 insertions(+), 164 deletions(-)
 create mode 100644 app/views/middleware_server/_existing_driver.html.haml
 create mode 100644 app/views/middleware_server/_specify_driver.html.haml

https://github.com/ManageIQ/manageiq/pull/14421

Yes, this can be moved to POST and backported to euwe.

Tested on revision CFME 5.7.2.0.20170321181409_349f1b1
Middleware Manager revision 0.33.0.Final-redhat-1 

The JDBC Drivers are shown doubled in the list while choosing them.

Steps to reproduce:
1. Make sure there are several JDBC Drivers on EAP7 server side.
2. Try to Add Datasoruce.
3. in Existing JDBC Driver tab try to choose driver from list.
The existing JDBC Drivers are shown them doubled, one list after another.
Screenshot is attached.

For the CFME 5.8.0.8-alpha1.20170328221054_e6ca7a2 with the same Middleware Manager it works correctly.

Created attachment 1268631 [details]
jdbc drivers

Hmmm @Hayk I'm not able to reproduce. With multiple Drivers I still see I attached my screenshot.

Created attachment 1271577 [details]
A couple JDBC Drivers with no repeating effects. Not reproducible for me.

I am still able to reproduce this issue. 
Have created 5 drivers: oracle, db2, mssql, edb, sybase. It happens even with only one driver.

CFME version 5.7.2.1.20170406142927_0a1ad0e 
Hawkular-Services version: 0.23.0.Final-redhat-1

I've tried to reproduce, but it worked for me. Here is what I did:

1. set up the middleware provider:
https://pastebin.com/npm5ejeE

2. adding it to MiQ@euwe and invoking the refresh

3. when trying to add the datasource, there were no duplicates in the combo-box, as shown on the screenshot:

http://imgur.com/a/r3PGs

(In reply to Jirka Kremser from comment #13)
> I've tried to reproduce, but it worked for me. Here is what I did:
> 
> 1. set up the middleware provider:
> https://pastebin.com/npm5ejeE
> 
> 2. adding it to MiQ@euwe and invoking the refresh
> 
> 3. when trying to add the datasource, there were no duplicates in the
> combo-box, as shown on the screenshot:
> 
> http://imgur.com/a/r3PGs

ok, so please close is as not reproducible

Looking into to screenshots, it was tested on MiQ. 
But the issue happens on CFME 5.7.2.1.
Also, here it describes choosing datasource:
> 3. when trying to add the datasource, there were no duplicates in the
> combo-box, as shown on the screenshot:
but the issue is on next steps, when JDBC Driver is chosen.

I am able to reproduce it again on CFME 5.7.2.1.20170406142927_0a1ad0e.

Hayk, is this behaving as expected in latest miq? (not 5.7.x)

Yes, it is working as expected on latest MiQ and on CFME 5.9.x

(In reply to Hayk Hovsepyan from comment #17)
> Yes, it is working as expected on latest MiQ and on CFME 5.9.x

super. I'm closing this one, it already has a linked clone for the other versions to indicate it was fixed there.
thank you Hayk!