Bug 1426908

Summary: Cancel edit cloud subnet throw undefined method `empty?' for nil:NilClass
Product: Red Hat CloudForms Management Engine Reporter: Ronnie Rasouli <rrasouli>
Component: UI - OPSAssignee: Eric Hayes <ehayes>
Status: CLOSED CURRENTRELEASE QA Contact: Omri Hochman <ohochman>
Severity: high Docs Contact:
Priority: high    
Version: 5.7.0CC: dclarizi, hkataria, jhardy, mpovolny, obarenbo, simaishi
Target Milestone: GAKeywords: TestOnly, ZStream
Target Release: 5.8.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: openstack:ui
Fixed In Version: 5.8.0.3 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1427522 (view as bug list) Environment:
Last Closed: 2017-06-12 17:33:34 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: Bug
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: Openstack Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1427522    
Attachments:
Description Flags
last 1500 lines of evm.log, prodiction log none

Description Ronnie Rasouli 2017-02-26 10:00:50 UTC
Created attachment 1257798 [details]
last 1500 lines of evm.log, prodiction log

Description of problem:
Edit cloud provider throws  Unexpected error encountered 
undefined method `empty?' for nil:NilClass [cloud_subnet/update] 

Version-Release number of selected component (if applicable):
5.7.1.3

How reproducible:
100%

Steps to Reproduce:
1. login to CFME UI
2. navigate to network --> cloud subnet 
3. select one of existing cloud subnets
4. click on edit
5. click cancel

Actual results:
undefined method `empty?' for nil:NilClass [cloud_subnet/update] 

Expected results:
return the previous page with flash message action was canceled by user

Additional info:

Comment 3 CFME Bot 2017-02-27 20:57:50 UTC
New commit detected on ManageIQ/manageiq-ui-classic/master:
https://github.com/ManageIQ/manageiq-ui-classic/commit/7f9344742299554e7d4adc0d25f5077c8fb2f98b

commit 7f9344742299554e7d4adc0d25f5077c8fb2f98b
Author:     Eric Hayes <eric>
AuthorDate: Mon Feb 27 11:29:04 2017 -0800
Commit:     Eric Hayes <eric>
CommitDate: Mon Feb 27 11:30:09 2017 -0800

    Replace `empty?` with `blank?` to catch empty strings and nils.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1426908

 app/controllers/cloud_subnet_controller.rb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comment 5 Ronnie Rasouli 2017-03-07 11:49:38 UTC
verified on 5.8.0.3