Bug 1427098

New version with fixed VR and added python2-devel and python3-devel as BRs.

Spec URL: https://amoralej.fedorapeople.org/python-kubernetes/python-kubernetes.spec
SRPM URL: https://amoralej.fedorapeople.org/python-kubernetes/python-kubernetes-1.0.0-0.1.b3.fc26.src.rpm

Scratch build in https://koji.fedoraproject.org/koji/taskinfo?taskID=18092556

Hi Alfredo,

The python3-%{library}-tests subpackage is including stuff from python2_sitelib. Other than that, it looks ok to me.

Fixed in:

Spec URL: https://amoralej.fedorapeople.org/python-kubernetes/python-kubernetes.spec
SRPM URL: https://amoralej.fedorapeople.org/python-kubernetes/python-kubernetes-1.0.0-0.2.b3.fc26.src.rpm

Thanks for the updates. The package is APPROVED, please proceed with the SCM request.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Apache (v2.0)", "Unknown or generated", "*No copyright* Apache
     (v2.0)". 892 files have unknown license. Detailed output of
     licensecheck in /tmp/1427098-python-kubernetes/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/lib/python3.6/site-
     packages, /usr/lib/python3.6
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     python2-kubernetes , python2-kubernetes-tests , python3-kubernetes ,
     python3-kubernetes-tests
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python2-kubernetes-1.0.0-0.2.b3.fc26.noarch.rpm
          python2-kubernetes-tests-1.0.0-0.2.b3.fc26.noarch.rpm
          python3-kubernetes-1.0.0-0.2.b3.fc26.noarch.rpm
          python3-kubernetes-tests-1.0.0-0.2.b3.fc26.noarch.rpm
          python-kubernetes-1.0.0-0.2.b3.fc26.src.rpm
python2-kubernetes-tests.noarch: W: no-documentation
python3-kubernetes-tests.noarch: W: no-documentation
python-kubernetes.src: W: summary-ended-with-dot C Python client for the kubernetes API.
python-kubernetes.src:140: W: macro-in-comment %{__python2}
python-kubernetes.src:190: W: macro-in-%changelog %files
5 packages and 0 specfiles checked; 0 errors, 5 warnings.




Rpmlint (installed packages)
----------------------------
python2-kubernetes-tests.noarch: W: no-documentation
python3-kubernetes-tests.noarch: W: no-documentation
4 packages and 0 specfiles checked; 0 errors, 2 warnings.



Requires
--------
python2-kubernetes-tests (rpmlib, GLIBC filtered):
    python(abi)
    python-mock
    python-nose
    python-py
    python2-kubernetes

python2-kubernetes (rpmlib, GLIBC filtered):
    PyYAML
    python(abi)
    python-certifi
    python-dateutil
    python-ipaddress
    python-oauth2client
    python-setuptools
    python-six
    python-urllib3
    python-websocket-client

python3-kubernetes (rpmlib, GLIBC filtered):
    python(abi)
    python3-PyYAML
    python3-certifi
    python3-dateutil
    python3-oauth2client
    python3-setuptools
    python3-six
    python3-urllib3
    python3-websocket-client

python3-kubernetes-tests (rpmlib, GLIBC filtered):
    python(abi)
    python3-kubernetes
    python3-mock
    python3-nose
    python3-py



Provides
--------
python2-kubernetes-tests:
    python2-kubernetes-tests

python2-kubernetes:
    python-kubernetes
    python2-kubernetes
    python2.7dist(kubernetes)
    python2dist(kubernetes)

python3-kubernetes:
    python3-kubernetes
    python3.6dist(kubernetes)
    python3dist(kubernetes)

python3-kubernetes-tests:
    python3-kubernetes-tests



Source checksums
----------------
https://github.com/kubernetes-incubator/client-python/archive/v1.0.0b3.tar.gz :
  CHECKSUM(SHA256) this package     : c3c31ee2b7f3a99e9248dbcee338148d9829f263017d1175ab813ad796472aa5
  CHECKSUM(SHA256) upstream package : c3c31ee2b7f3a99e9248dbcee338148d9829f263017d1175ab813ad796472aa5


Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1427098 -m fedora-rawhide-x86_64
Buildroot used: fedora-rawhide-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

New package requested in pkgdb

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-kubernetes

Package built in https://koji.fedoraproject.org/koji/buildinfo?buildID=862968